Conversation
simonklb
left a comment
simonklb
left a comment
There was a problem hiding this comment.
The PR description is a bit lacking. What is this and why are you doing it?
|
this fixes the building of the 'image-builder' from the main branch, i missed this change from the previous PR. |
| run: make docker-build | ||
| env: | ||
| TAG: ${{ steps.get-tag.outputs.TAG }} | ||
| TAG: main |
There was a problem hiding this comment.
Suggestion: This would overwrite the main tag each time? Wouldn't we also want the commit hash to be able to use older builds if needed?
Maybe both, so you can reference the latest build with main but also have a copy of each commit?
There was a problem hiding this comment.
We can create an issue for that as a CI task
| run: make docker-build | ||
| env: | ||
| TAG: ${{ steps.get-tag.outputs.TAG }} | ||
| TAG: main |
There was a problem hiding this comment.
Question: Can't find this target in the root Makefile. I assume this is this target. If so wouldn't we need to add this?
| TAG: main | |
| TAG: main | |
| working-directory: ./images/capi |
There was a problem hiding this comment.
I might have unintentionally removed the working-directory
3 participants
Change description
Related issues
Additional context