Skip to content

fix(worker): register leader-now listener early to prevent race condition #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaigritun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(worker): register leader-now listener early to prevent race condition #890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions packages/pglite/src/worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,18 @@ export class PGliteWorker
// Wait for the worker let us know it's ready
await this.#workerReadyPromise

// Register leader-now listener early to avoid race condition (#850)
// The worker may send 'leader-now' immediately after becoming leader,
// before we've finished setting up broadcast channels. By registering
// this listener before any async operations, we ensure we don't miss
// the message.
this.#workerProcess.addEventListener('message', async (event) => {
if (event.data.type === 'leader-now') {
this.#isLeader = true
this.#eventTarget.dispatchEvent(new Event('leader-change'))
}
})

// Acquire the tab close lock, this is released then the tab, or this
// PGliteWorker instance, is closed
const tabCloseLockId = `pglite-tab-close:${this.#tabId}`
Expand Down Expand Up @@ -180,13 +192,6 @@ export class PGliteWorker
}
})

this.#workerProcess.addEventListener('message', async (event) => {
if (event.data.type === 'leader-now') {
this.#isLeader = true
this.#eventTarget.dispatchEvent(new Event('leader-change'))
}
})

this.#leaderNotifyLoop()

// Init array types
Expand Down