You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR migrates us to oxc.rs from ESLint/Prettier. Going to do this across all Ecosystem WG-owned repos.
Migration guidelines
Formatting
Existing Prettier configuration ported to oxfmt to minimize diff.
Markdown and YAML ignored.
Linting
oxlint configuration intentionally kept minimal. All default plugins enabled, with import added as well.
TypeScript repos attempt to use typeAware mode via oxlint-tsgolint.
This is sometimes impossible in a straight migration due to legacy moduleResolution: node settings. This is noted whenever relevant.
Other
husky + lint-staged set up for pre-commit hooks.
package.json scripts standardized as lint and lint:fix.
typescript dependency upgraded to v6 for building the repos. We maintain configuration compatibility with tsgo while keeping a stable version of TypeScript.
Where relevant (for packages.electronjs.org repos) typedoc is upgraded to 0.28 accordingly, but this triggers some socket.dev warnings that I would like reviewers to mark as acceptable risk.
Next steps: Take a moment to review the security alert above. Review
the linked package source code to understand the potential risk. Ensure the
package is not malicious before proceeding. If you're unsure how to proceed,
reach out to your security team or ask the Socket team for help at
support@socket.dev.
Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.
Mark the package as acceptable risk. To ignore this alert only
in this pull request, reply with the comment
@SocketSecurity ignore npm/entities@4.5.0. You can
also ignore all packages with @SocketSecurity ignore-all.
To ignore an alert for all future pull requests, use Socket's Dashboard to
change the triage state of this alert.
Block
Obfuscated code: npm markdown-it is 91.0% likely obfuscated
Next steps: Take a moment to review the security alert above. Review
the linked package source code to understand the potential risk. Ensure the
package is not malicious before proceeding. If you're unsure how to proceed,
reach out to your security team or ask the Socket team for help at
support@socket.dev.
Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.
Mark the package as acceptable risk. To ignore this alert only
in this pull request, reply with the comment
@SocketSecurity ignore npm/markdown-it@14.1.1. You can
also ignore all packages with @SocketSecurity ignore-all.
To ignore an alert for all future pull requests, use Socket's Dashboard to
change the triage state of this alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates us to oxc.rs from ESLint/Prettier. Going to do this across all Ecosystem WG-owned repos.
Migration guidelines
Formatting
Linting
importadded as well.typeAwaremode viaoxlint-tsgolint.moduleResolution: nodesettings. This is noted whenever relevant.Other
husky+lint-stagedset up for pre-commit hooks.lintandlint:fix.typescriptdependency upgraded to v6 for building the repos. We maintain configuration compatibility withtsgowhile keeping a stable version of TypeScript.typedocis upgraded to0.28accordingly, but this triggers some socket.dev warnings that I would like reviewers to mark as acceptable risk.Full list of PRs
TODO: