feat(plugin-vite): upgrade vite to version 8.0.0#4167
feat(plugin-vite): upgrade vite to version 8.0.0#41670xlau wants to merge 4 commits intoelectron:nextfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
@SocketSecurity ignore npm/vite@8.0.0 |
|
@SocketSecurity ignore npm/vite@8.0.0 |
| const contents = fs.readFileSync(outFile, 'utf8'); | ||
| // MAIN_WINDOW_VITE_NAME should be statically replaced with "main_window" | ||
| expect(contents).toContain('"main_window"'); | ||
| expect(contents).toMatch(/["'`]main_window["'`]/); |
There was a problem hiding this comment.
Does this map to some breaking change in Vite 7 -> 8?
|
Hi, I'm using the latest stable version of Electron Forge (v7.11.1). After I updated Vite to v8, I encountered a warning when running my application: I guess we need to adjust the |
close #4166
Summary
This PR updates
@electron-forge/plugin-viteto support Vite 8.Electron Forge
nextcurrently uses Vite 7, while Vite 8 has already been released. This change updates the plugin so projects using Electron Forge can adopt the latest Vite version.Changes
Testing
Tested with a local Electron Forge project using
@electron-forge/plugin-viteand Vite 8.Build, dev server, and renderer reload all work as expected.