Update report index.html (#2099) #2101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds --s3-acl option to the cli to be able to set S3 report permissions.
Fixed setup of internal dbt project used by Elementary
Add function for `disable_elementary_logo_print`
…-startup-for-elementary-tests added clickhouse startup
…kage-0.18.3-in-cli
…-0.18.3-in-cli updated to 0.18.3
…report-to-cli update report to 1.0.26
release/v0.18.2
…trics-in-cli fixed missing metrics in cli
release/v0.18.3
…context-in-integration added message context parsing
…ata-alerts Add orchestrator jobs data to alerts
This reverts commit 2d071b1.
This reverts commit c8ed0b2.
…wo-tests-in-dashboard Include Seeds and Snapshots w/o Tests in Dashboard
…-as-comment-to-cloud-queries Update dbt package reference
Co-authored-by: Yosef Arbiv <yosef@elementary-data.com>
* feat: quiet-logs flag * fix: include quiet_logs in config. make it a flag * fix: initiate self.quiet_logs in the Config constructor --------- Co-authored-by: Yosef Arbiv <yosef@elementary-data.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
…onfig file (#2093) * defaulting target_path to none to allow check for target_path in config file * removing print statements --------- Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
* Update the version constrains of `google-cloud-storage` Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com> * chore: tighten google-cloud-storage constraint to <3.2 for dbt-bigquery 1.10.3 compatibility --------- Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
* Run CLI tests on all warehouses instead of just Postgres - Add pull_request_target trigger to test-all-warehouses.yml - Add workflow_call trigger for reusability - Remove dbt 1.8.0 from matrix, run only on latest version - Update elementary-ref to use PR head SHA for pull_request_target events - Skip Slack notifications for PR failures to avoid spam - Delete test-main-warehouse.yml (superseded by test-all-warehouses.yml) Resolves ELE-5218 Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Remove workflow_call trigger (not used by any other workflow) Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
* remove python 3.9 * silence mypy error when subclassing click.MultiCommand * use newer actions/setup-python version --------- Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
…2090) ClickHouse does not support standard SQL UPDATE statements. Instead, it requires ALTER TABLE ... UPDATE syntax for mutations. This change adds adapter dispatch for the update_skipped_alerts and update_sent_alerts macros to use the correct ClickHouse syntax when running on ClickHouse adapters. Fixes ClickHouse syntax error (Code 62) when running 'edr monitor'. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Yosef Arbiv <yosef.arbiv@gmail.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
click.MultiCommand is deprecated and will be removed in click 9. This change migrates to click.Group which is the recommended replacement. - Changed ElementaryCLI base class from click.MultiCommand to click.Group - Replaced @click.command with @click.group decorator - Removed _CMD_MAP dictionary and list_commands() method - Added commands using cli.add_command() instead - Updated get_command() to call super().get_command() Fixes ELE-5220 Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
* Re-enable ClickHouse in CLI tests Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Fix prettier formatting for warehouse-type array Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Add clickhouse to Seed e2e dbt project step Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Fix get_elementary_database_and_schema to use actual elementary schema Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Revert "Fix get_elementary_database_and_schema to use actual elementary schema" This reverts commit 1fc1952. * Fix ClickHouse column alias handling in populate_test_alerts macro Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Use .get() for all field accesses in populate_test_alerts to handle ClickHouse column names Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Revert "Use .get() for all field accesses in populate_test_alerts to handle ClickHouse column names" This reverts commit 5a7efb8. * Revert "Fix ClickHouse column alias handling in populate_test_alerts macro" This reverts commit a3bef9c. * Add debug logging to identify Undefined field in populate_test_alerts Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Update debug logging to use 'is defined' checks for accurate Undefined detection Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Add more detailed debug logging to find nested Undefined values Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Fix ClickHouse column alias handling with .get() fallbacks ClickHouse returns columns with table prefix (e.g., 'failed_tests.database_name' instead of 'database_name'). Use .get() with fallbacks to handle both naming conventions for the affected fields: - database_name - schema_name - tags - test_params - severity - status - result_rows Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Fix ClickHouse column name ambiguity with explicit SQL aliases ClickHouse returns columns with table prefix when column names are ambiguous across joined tables. The affected columns (database_name, schema_name, tags, test_params, severity, status, result_rows) exist in both failed_tests and tests tables. Fix: Add explicit 'as column_name' aliases in the SQL query to force ClickHouse to use the alias name instead of the qualified column name. This is cleaner than using .get() fallbacks in the macro. Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Remove DBT_EDR_DEBUG env var (debugging complete) Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
* dbt version bump
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
Co-authored-by: GitHub Actions <noreply@github.com>
#2097) * Improve fork safety: consolidate approval and add pull_request trigger - Add pull_request trigger for internal PRs (non-forks) to test workflow changes immediately - Keep pull_request_target for fork PRs that need access to secrets - Move approval step to test-all-warehouses.yml (runs once instead of per-platform) - Remove per-platform approval from test-warehouse.yml to reduce spam Fixes ELE-5221 Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Fix: use !cancelled() and check fork-status result before running tests Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Remove redundant comment on test job condition Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Refactor: move should_skip logic inside PR event check block Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
…refs warnings (#2108) * Replace deprecated update_forward_refs() with version-conditional model_rebuild() Use model_rebuild() when running under pydantic v2, fall back to update_forward_refs() for pydantic v1 compatibility. This eliminates PydanticDeprecatedSince20 warnings in downstream projects using pydantic v2. Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Use pydantic_shim for BaseModel in messages package Switch all messages modules from 'from pydantic import BaseModel' to 'from elementary.utils.pydantic_shim import BaseModel'. This uses the existing v1 shim so update_forward_refs() is the native v1 API call and no PydanticDeprecatedSince20 warnings are emitted under pydantic v2. Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Fix import sorting for isort --profile black Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Convert remaining from pydantic import BaseModel to use pydantic_shim Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> * Fix isort ordering for pydantic_shim imports Co-Authored-By: Itamar Hartstein <haritamar@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
…#2109) The `get_log_path` function had a `return` statement inside a `finally` block, which silently swallows any in-flight exceptions including `BaseException` subclasses like `KeyboardInterrupt`. Replace the `try/finally` with a proper `try/except` that catches the expected `ValueError` (from `list.index()`) and `IndexError` (from accessing the next argument), then move the directory creation and return statement outside the exception handler. Fixes #1731 Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
…2110) When a dbt exposure owner is configured as a plain string (e.g., `owner: username`) instead of a dict with name/email fields, the ExposureSchema validation fails because Pydantic cannot coerce a string into an OwnerSchema. Add a pre-validator on the `owner` field that converts a string value into an OwnerSchema instance with the string as the name, matching the existing pattern used by `_load_var_to_list` for other fields. Fixes #1732 Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
…ne.utc) (#2111) `datetime.utcnow()` has been deprecated since Python 3.12 because it returns a naive datetime that carries no timezone information, making it error-prone when mixed with timezone-aware datetimes. Replace all 8 occurrences across 7 files (5 source, 2 test) with the recommended `datetime.now(tz=timezone.utc)` which returns a proper timezone-aware datetime. Files changed: - elementary/utils/time.py - elementary/monitor/fetchers/alerts/schema/pending_alerts.py - elementary/monitor/data_monitoring/alerts/data_monitoring_alerts.py - elementary/messages/messaging_integrations/teams_webhook.py - elementary/messages/messaging_integrations/slack_webhook.py - elementary/messages/messaging_integrations/file_system.py - tests/unit/monitor/fetchers/alerts/schemas/test_alert_data_schema.py - tests/mocks/fetchers/alerts_fetcher_mock.py Co-authored-by: themavik <themavik@users.noreply.github.com> Co-authored-by: Itamar Hartstein <haritamar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.