Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “Image Resizer” Stream Deck plugin sample that demonstrates using a Node native addon dependency (sharp) inside a bundled plugin.
Changes:
- Introduces an
Image Resizeraction that resizes a user-selected image viasharp. - Adds Rollup/TypeScript build configuration and scripts intended to bundle native dependencies into the
.sdPlugin. - Adds a property inspector UI, manifest, and plugin assets/documentation for the new sample.
Reviewed changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| image-resizer/tsconfig.json | TypeScript configuration for the new sample. |
| image-resizer/src/plugin.ts | Stream Deck plugin entrypoint registering the action and connecting. |
| image-resizer/src/actions/resize-image.ts | Action implementation calling sharp to resize and write output images. |
| image-resizer/rollup.config.mjs | Rollup build pipeline, including copying native-module artifacts into the plugin bundle. |
| image-resizer/package.json | Build/watch scripts plus multi-platform sharp install scripts. |
| image-resizer/com.elgato.image-resizer.sdPlugin/ui/resize-image.html | Property inspector UI to select image, output format, and dimensions. |
| image-resizer/com.elgato.image-resizer.sdPlugin/manifest.json | Declares the plugin/action, Node runtime version, and platform requirements. |
| image-resizer/com.elgato.image-resizer.sdPlugin/imgs/plugin/* | New icons/marketplace images for the plugin. |
| image-resizer/README.md | Explains how to build/link and the intended native-module bundling approach. |
| image-resizer/.vscode/settings.json | VS Code JSON schema hints for plugin manifests/layouts. |
| image-resizer/.vscode/launch.json | VS Code debug attach configuration for the plugin. |
| image-resizer/.gitignore | Ignores node_modules and .sdPlugin build outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 19 changed files in this pull request and generated 8 comments.
Files not reviewed (1)
- image-resizer/com.elgato.image-resizer.sdPlugin/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 19 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- image-resizer/com.elgato.image-resizer.sdPlugin/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 6 comments.
Files not reviewed (1)
- image-resizer/com.elgato.image-resizer.sdPlugin/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e.html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| !isWatching && terser(), | ||
| { | ||
| name: "emit-module-package-file", | ||
| generateBundle() { |
There was a problem hiding this comment.
If I understand correctly, emit-module-package-file should be removed — step 2 mentions that dependencies should be defined in the package.json in the bin, but this step replaces the contents of the same file.
There was a problem hiding this comment.
@ChekTek, I think this might need to be re-introduced now that we're using the pnpm approach as currently there isn't a package.json committed or generated in the bin folder.
No description provided.