Unwrap scim errors when possible for patch validation#187
Merged
q-uint merged 1 commit intoelimity-com:masterfrom Mar 24, 2026
Merged
Unwrap scim errors when possible for patch validation#187q-uint merged 1 commit intoelimity-com:masterfrom
q-uint merged 1 commit intoelimity-com:masterfrom
Conversation
Achooo
force-pushed
the
ash/issue-186-fix-patch-errors
branch
from
543ec92 to
b679fb0
Compare
Achooo
commented
Apr 23, 2025
| } | ||
| value, err := validator.Validate() | ||
| if err != nil { | ||
| return nil, &errors.ScimErrorInvalidValue |
Contributor
Author
There was a problem hiding this comment.
New logic to unwrap the underlying scim error (this does assume/require underlying errors returned are pointers as best practice to work properly, which does seem to be the case).
Please let me know if any other tests should be added as I only noticed the handlers_test.go tests. 🙏🏽
q-uint
approved these changes
Mar 24, 2026
Collaborator
q-uint
left a comment
q-uint
left a comment
There was a problem hiding this comment.
Thanks, LGTM! Nice catch preserving the specific SCIM error instead of swallowing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186
Attempt to fix the scimErrors that are overwritten in the patch validation logic. Feel free to modify / close this PR, just a proposed fix 💯