Label the connection with the repo name#698
Open
nathanl wants to merge 2 commits intoelixir-ecto:masterfrom
Open
Label the connection with the repo name#698nathanl wants to merge 2 commits intoelixir-ecto:masterfrom
nathanl wants to merge 2 commits intoelixir-ecto:masterfrom
Conversation
nathanl
added a commit
to nathanl/db_connection
that referenced
this pull request
Nov 17, 2025
The label must be passed in - see elixir-ecto/ecto_sql#698 Assuming it's the repo name, this is helpful if the application has more than one repo (eg read replicas). For example: Before: "** (DBConnection.ConnectionError) connection is closed because of an error, disconnect or timeout" After: "** (DBConnection.ConnectionError) MyApp.Repo connection is closed because of an error, disconnect or timeout"
nathanl
force-pushed
the
label_connection
branch
from
cf18870 to
645ec64
Compare
nathanl
added a commit
to nathanl/db_connection
that referenced
this pull request
Nov 17, 2025
The label must be passed in - see elixir-ecto/ecto_sql#698 Assuming it's the repo name, this is helpful if the application has more than one repo (eg read replicas). For example: Before: "** (DBConnection.ConnectionError) connection is closed because of an error, disconnect or timeout" After: "** (DBConnection.ConnectionError) MyApp.Repo connection is closed because of an error, disconnect or timeout"
josevalim
reviewed
Nov 17, 2025
nathanl
added a commit
to nathanl/db_connection
that referenced
this pull request
Dec 1, 2025
A label like MyApp.Repo can be passed via the :label option. It will be used in the process label for the DBConnection.Ownership.Manager process and will appear in error messages from both DBConnection.Ownership.Manager and DBConnection.Holder. This is helpful when applications use multiple repos (e.g., read replicas). Before: (DBConnection.OwnershipError) cannot find ownership process for #PID<...> (DBConnection.ConnectionError) connection is closed because of an error... After: (DBConnection.OwnershipError) cannot find ownership process for #PID<...> (MyApp.Repo) using mode :manual. (DBConnection.ConnectionError) MyApp.Repo connection is closed because of an error, disconnect or timeout Tests verify labels appear correctly in both error types, and that errors work correctly if no label is given. In elixir-ecto/ecto_sql#698 the adapter is updated to pass the repo name as a label.
nathanl
added a commit
to nathanl/db_connection
that referenced
this pull request
Dec 1, 2025
A label like MyApp.Repo can be passed via the :label option. It will be used in the process label for the DBConnection.Ownership.Manager process and will appear in error messages from both DBConnection.Ownership.Manager and DBConnection.Holder. This is helpful when applications use multiple repos (e.g., read replicas). Before: (DBConnection.OwnershipError) cannot find ownership process for #PID<...> (DBConnection.ConnectionError) connection is closed because of an error... After: (DBConnection.OwnershipError) cannot find ownership process for #PID<...> (MyApp.Repo) using mode :manual. (DBConnection.ConnectionError) MyApp.Repo connection is closed because of an error, disconnect or timeout Tests verify labels appear correctly in both error types, and that errors work correctly if no label is given. In elixir-ecto/ecto_sql#698 the adapter is updated to pass the repo name as a label.
nathanl
added a commit
to nathanl/db_connection
that referenced
this pull request
Dec 1, 2025
A label like MyApp.Repo can be passed via the :label option. It will be used in the process label for the DBConnection.Ownership.Manager process and will appear in error messages from both DBConnection.Ownership.Manager and DBConnection.Holder. This is helpful when applications use multiple repos (e.g., read replicas). Before: (DBConnection.OwnershipError) cannot find ownership process for #PID<...> (DBConnection.ConnectionError) connection is closed because of an error... After: (DBConnection.OwnershipError) cannot find ownership process for #PID<...> (MyApp.Repo) using mode :manual. (DBConnection.ConnectionError) MyApp.Repo connection is closed because of an error, disconnect or timeout Tests verify labels appear correctly in both error types, and that errors work correctly if no label is given. In elixir-ecto/ecto_sql#698 the adapter is updated to pass the repo name as a label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See elixir-ecto/db_connection#332