Add typespecs, property tests, and dialyzer CI#288
Open
dylantirandaz wants to merge 1 commit intoelixir-horde:masterfrom
Open
Add typespecs, property tests, and dialyzer CI#288dylantirandaz wants to merge 1 commit intoelixir-horde:masterfrom
dylantirandaz wants to merge 1 commit intoelixir-horde:masterfrom
Conversation
Collaborator
|
@dylantirandaz please you will fix the conflicts? |
- Add @impl and @SPEC to UniformDistribution, UniformQuorumDistribution, UniformRandomDistribution, and TableUtils - Fix DistributionStrategy callback spec: error reason is atom(), not String.t(); has_quorum? can return nil - Add property-based tests: determinism for UniformDistribution, quorum majority correctness for UniformQuorumDistribution, has_quorum? invariant for UniformRandomDistribution - Add Dialyzer job to CI with PLT caching - Rename disown_child_process to release_child_process
dylantirandaz
force-pushed
the
add-specs-and-quorum-tests
branch
from
32ad49a to
73c73b9
Compare
Contributor
Author
|
yes fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@impland@specannotations to all distribution strategy modules (UniformDistribution,UniformQuorumDistribution,UniformRandomDistribution) andTableUtilsDistributionStrategycallback spec: error reason was typed asString.t()but all implementations return atoms;has_quorum?/1can returnnilfor quorum distribution when all nodes are shutting downUniformDistribution, majority-alive correctness forUniformQuorumDistribution, andhas_quorum?/1invariant forUniformRandomDistributiondisown_child_processmessage torelease_child_process(resolves TODO inDynamicSupervisorImpl)Test plan
mix format --check-formattedpassesmix testpasses (106 tests, 8 properties, 0 failures related to changes)mix dialyzerpasses with 0 errors