fix(mint): avoid active-mode message races without breaking reused connections#812
Merged
yordis merged 1 commit intoelixir-tesla:masterfrom Apr 18, 2026
Merged
Conversation
This was referenced Nov 4, 2025
yordis
reviewed
Nov 4, 2025
…nnections Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
fix_mint_unkwnown_message
branch
from
22882dd to
755617c
Compare
yordis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix #811
Reading the issue #357 and the subsequent PR, it seems that the desired fix was to set the default mint mode to passive, however it was not really set because of the reasons outlined in #811
A related change is to avoid wrapping the timeout transport error in a string when passive mode is used: currently the
receive_messagefunction returns a{:error, :timeout}error when in active mode, a mint error when in passive, which is then wrapped in a{:error, "Encounter Mint error %Mint.TransportError{reason: :timeout}"}tuple. This was changed to avoid incoherent errors between the two modes.Please let me know if this is an acceptable way to fix the timeout return value inconsistency or it is better to leave it as it is (and instead fix the test) because it would technically introduce a breaking change in the api