Open
Conversation
This fixes two isses: clipped glyphs for when the computed bounding box does not match the actual bounding box and glyphs leaking into others.
Member
|
Looks good at first glance. Can you provide a font file which shows this issue, so that I can test it myself? I have another unmerged branch that might interfere with these changes and I want to make sure I don't accidentally break the fix again. |
rfuest
reviewed
Mar 2, 2026
| .glyphs | ||
| .iter() | ||
| .filter_map(|g| { | ||
| matches!(g.encoding, Encoding::Standard(_)) |
Member
There was a problem hiding this comment.
Why does this ignore glyphs without a standard encoding?
Author
There was a problem hiding this comment.
I am not too familiar with the codebase and followed basically what was done in line 104 and 116.
Author
I am not sure if the font license allows redistributing but it should be fairly easy to reproduce. I used otf2bd to produce a 64 pixel tall rendition of Archivo Narrow with otf2bdf -r 72 -p 64 ArchivoNarrow-Regular.ttf -o archivo.bdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two isses: clipped glyphs for when the computed bounding box does not match the actual bounding box and glyphs leaking into others.