Restore search to the website-redesign branch#962
Merged
MinThaMie merged 12 commits intowebsite-redesignfrom Sep 11, 2025
Merged
Restore search to the website-redesign branch#962MinThaMie merged 12 commits intowebsite-redesignfrom
MinThaMie merged 12 commits intowebsite-redesignfrom
Conversation
- Remove unit test of metrics tracking but add local metrics adapter to observe metrics tracking
✅ Deploy Preview for ember-api-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… with the component from the guides in style - Now navigable by screen readers (tested with Voiceover) - Not 100% spec a11y but a big improvement over the previous search that was not usable at all by screen readers
kategengler
force-pushed
the
kg-website-redesign
branch
from
f6af180 to
31cc450
Compare
MinThaMie
approved these changes
Sep 11, 2025
Contributor
MinThaMie
left a comment
MinThaMie
left a comment
There was a problem hiding this comment.
LGTM :)Thanks for moving it to gjs. The alignment in the preview seems off, but we can fix that in the tracking branch if it persists there
Contributor
Author
|
I'm working on the alignment. It's correct locally and it is down to a bug in the css optimizer in embroider stripping media queries embroider-build/embroider#1358 |
Contributor
|
Hmm, that's weird! Thanks for looking into That, because we will probably need to fix that in the style guide at some point too. |
Contributor
Author
|
I fixed it in #963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplemented in a new component in a style matching the guides search. Results are now navigable by screen readers.