[WIP]: bump things depending on old ember string#1680
Open
MichalBryxi wants to merge 5 commits intoember-learn:mainfrom
Open
[WIP]: bump things depending on old ember string#1680MichalBryxi wants to merge 5 commits intoember-learn:mainfrom
MichalBryxi wants to merge 5 commits intoember-learn:mainfrom
Conversation
- This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues - Since we have `capitalize` in @ember/string, we can just call that in our internal helper - Also bumped internal version of @ember/string to v4.x Fixes ember-learn#1666
- The package insists on having @ember/string v3 - It does not do too much
To get rid of: ``` ERROR in ../rewritten-packages/ember-modal-dialog.6bc4f645/node_modules/ember-modal-dialog/components/liquid-tether-dialog.js 35:0-42 Module not found: Error: ember-modal-dialog is trying to import the app's @ember/string package, but it seems to be missing @ ../../.pnpm/@embroider+babel-loader-9@3.1.1_@embroider+core@3.5.6_supports-color@8.1.1_webpack@5.97.1/node_modules/@embroider/babel-loader-9/index.js?{"variant":{"name":"dev","runtime":"browser","optimizeForProduction":false},"appBabelConfigPath":"/Users/michal/ember/ember-cli-addon-docs/node_modules/.embroider/rewritten-app/_babel_config_.js","cacheDirectory":"$TMPDIR/embroider/webpack-babel-loader"}!../../.pnpm/@embroider+webpack@3.2.3_@embroider+core@3.5.6_webpack@5.97.1/node_modules/@embroider/webpack/src/virtual-loader.js?f=%2FUsers%2Fmichal%2Fember%2Fember-cli-addon-docs%2Fnode_modules%2F.embroider%2Frewritten-app%2F-embroider-implicit-modules.js&a=%2FUsers%2Fmichal%2Fember%2Fember-cli-addon-docs%2Ftests%2Fdummy! 12:13-74 @ ./assets/dummy.js 4:4-47 ``` # Conflicts: # package.json # pnpm-lock.yaml
To get rid of: ``` WARNING in ../rewritten-packages/ember-classy-page-object.4dd72acf/node_modules/ember-classy-page-object/extend.js 1:0-84 export 'getContext' (reexported as 'getContext') was not found in 'ember-cli-page-object/extend' (possible exports: buildSelector, findElement, findElementWithAssert, findMany, findOne, fullScope) @ ../../.pnpm/@embroider+babel-loader-9@3.1.1_@embroider+core@3.5.6_supports-color@8.1.1_webpack@5.97.1/node_modules/@embroider/babel-loader-9/index.js?{"variant":{"name":"dev","runtime":"browser","optimizeForProduction":false},"appBabelConfigPath":"/Users/michal/ember/ember-cli-addon-docs/node_modules/.embroider/rewritten-app/_babel_config_.js","cacheDirectory":"$TMPDIR/embroider/webpack-babel-loader"}!../../.pnpm/@embroider+webpack@3.2.3_@embroider+core@3.5.6_webpack@5.97.1/node_modules/@embroider/webpack/src/virtual-loader.js?f=%2FUsers%2Fmichal%2Fember%2Fember-cli-addon-docs%2Fnode_modules%2F.embroider%2Frewritten-app%2F-embroider-implicit-test-modules.js&a=%2FUsers%2Fmichal%2Fember%2Fember-cli-addon-docs%2Ftests%2Fdummy! 189:13-55 @ ./assets/test.js 6:4-52 ```
MichalBryxi
force-pushed
the
mb/1678-bump-things-depending-on-old-ember-string
branch
from
de80455 to
e901e21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.