Make generated API reference its own top-level section#231
Open
xcambar wants to merge 4 commits intoember-learn:mainfrom
Open
Make generated API reference its own top-level section#231xcambar wants to merge 4 commits intoember-learn:mainfrom
xcambar wants to merge 4 commits intoember-learn:mainfrom
Conversation
Contributor
Author
|
Here's the diff to be applied to diff --git a/tests/dummy/app/router.js b/tests/dummy/app/router.js
index 01b4a52..fc2c8c7 100644
--- a/tests/dummy/app/router.js
+++ b/tests/dummy/app/router.js
@@ -25,10 +25,6 @@ Router.map(function() {
this.route('1-belongs-to');
this.route('2-has-many');
});
-
- this.route('api', function() {
- this.route('class', { path: '/:class_id' });
- });
});
// this.route('contacts', { path: '/' });So it's actually less code to be written by the developer 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up comments on #230
I gave a shot at working on moving API docs to their own top-level section.
This PR provides the following significant features:
API Referencesection pointing to... well... the API reference/apiinstead of/docs/api/apianddocsdiffer in their contents (I assumed it was expected, but IMO it gives much more readable structure)/docs@samselikoff @pzuraq this should match your comments. Hope you'll like it. If so, this will close #230.