Simplify lexicalScope function by removing global check#21110
Merged
NullVoxPopuli merged 6 commits intonvp/add-tests-for-RFC-1070from Feb 21, 2026
Merged
Simplify lexicalScope function by removing global check#21110NullVoxPopuli merged 6 commits intonvp/add-tests-for-RFC-1070from
NullVoxPopuli merged 6 commits intonvp/add-tests-for-RFC-1070from
Conversation
Removed check for ALLOWED_GLOBALS in lexicalScope function.
Contributor
Estimated Asset SizesDiff --- main/out.txt 2026-02-17 19:37:18.000000000 +0000
+++ pr/./pr-22261160067/out.txt 2026-02-21 17:33:46.000000000 +0000
@@ -1,16 +1,16 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 351.99 KB │ 203.84 KB ║
+║ Total │ 352.56 KB │ 204.41 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.39 KB │ 181.91 KB ║
+║ Total │ 313.96 KB │ 182.59 KB ║
╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 36.65 KB │ 26.22 KB ║
-║ application │ 13.23 KB │ 8.05 KB ║
+║ -internals │ 36.65 KB │ 26.23 KB ║
+║ application │ 13.23 KB │ 8.09 KB ║
║ array │ 13.01 KB │ 7.46 KB ║
║ canary-features │ 304 B │ 389 B ║
║ component │ 2.05 KB │ 1.64 KB ║
@@ -19,18 +19,18 @@
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 1.08 KB │ 811 B ║
+║ helper │ 1.08 KB │ 803 B ║
║ instrumentation │ 2.43 KB │ 1.79 KB ║
-║ modifier │ 1.22 KB │ 965 B ║
+║ modifier │ 1.22 KB │ 966 B ║
║ object │ 35.94 KB │ 22.16 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 630 B │ 487 B ║
-║ routing │ 59.3 KB │ 34.12 KB ║
+║ renderer │ 630 B │ 492 B ║
+║ routing │ 59.33 KB │ 34.13 KB ║
║ runloop │ 2.36 KB │ 1.5 KB ║
║ service │ 1 KB │ 845 B ║
-║ template │ 654 B │ 541 B ║
+║ template │ 654 B │ 519 B ║
║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 123.08 KB │ 59.45 KB ║
+║ template-compiler │ 123.62 KB │ 60.09 KB ║
║ template-factory │ 370 B │ 374 B ║
║ test │ 923 B │ 627 B ║
║ utils │ 4.11 KB │ 3.6 KB ║
@@ -40,19 +40,19 @@
╔═════════════════╤══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼──────────┼──────────╢
-║ Total │ 38.6 KB │ 21.94 KB ║
+║ Total │ 38.6 KB │ 21.82 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable │ 2.77 KB │ 1.39 KB ║
║ encoder │ 81 B │ 171 B ║
║ env │ 38 B │ 87 B ║
║ global-context │ 886 B │ 545 B ║
║ manager │ 977 B │ 608 B ║
-║ node │ 175 B │ 260 B ║
+║ node │ 175 B │ 245 B ║
║ opcode-compiler │ 1.11 KB │ 894 B ║
║ owner │ 159 B │ 202 B ║
║ program │ 252 B │ 301 B ║
║ reference │ 548 B │ 531 B ║
-║ runtime │ 10.32 KB │ 5.32 KB ║
+║ runtime │ 10.32 KB │ 5.22 KB ║
║ tracking │ 1.34 KB │ 1.16 KB ║
║ util │ 1.94 KB │ 1.68 KB ║
║ validator │ 15.75 KB │ 6.96 KB ║Details
|
Update test to pass global variables into scope for explicit runtime template compiler tests.
Contributor
Author
|
@copilot run pnpm lint:fix |
Contributor
|
@NullVoxPopuli I've opened a new pull request, #21111, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Fix trailing whitespace in runtime template compiler test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed check for ALLOWED_GLOBALS in lexicalScope function.
Testing if PR comment from #21076 (comment) is accurate -- as I've forgotten (been too long!)