Open
Conversation
|
View snapshot changes at kitdiff |
There was a problem hiding this comment.
Pull request overview
Improves egui_plot line hover interaction by selecting the closest line segment to the cursor (instead of requiring precise point hovering), enabling more intuitive tooltips and highlighting.
Changes:
- Added a point-to-line-segment squared-distance helper in
math.rs. - Overrode
Line’sfind_closestto compute proximity to segments and select the best match for hover/tooltips.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
egui_plot/src/math.rs |
Adds dist_sq_to_segment used to measure cursor proximity to a line segment. |
egui_plot/src/items/series.rs |
Updates Line::find_closest to choose the nearest segment and map it to a data-point index for tooltip/highlight. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lucasmerlin
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will now find the line closest to the cursor, so you don't need to hover the points exactly
https://github.com/user-attachments/assets/6aec87b3-97ad-4f41-94a4-f38ea1b985da