Set -Wno-unsed-but-set-variable for compiler-rt and libcxxabi#26538
Set -Wno-unsed-but-set-variable for compiler-rt and libcxxabi#26538dschuff wants to merge 2 commits intoemscripten-core:mainfrom
Conversation
| '-D_LIBCXXABI_BUILDING_LIBRARY', | ||
| '-DLIBCXXABI_NON_DEMANGLING_TERMINATE', | ||
| '-std=c++23', | ||
| '-Wno-unused-but-set-variable', |
There was a problem hiding this comment.
Is this set in libcxxabi upstream too? Or have these warning been fixed on HEAD there?
There was a problem hiding this comment.
No, but the issue is present there. There's a static variable that is unread if _LIBCXXABI_NO_EXCEPTIONS is set. So maybe we should fix that upstream, but we'd probably still need to have this until the next time we roll libcxxabi into emscripten. likewise with compiler-rt when __BIONIC__ is not defined.
There was a problem hiding this comment.
Maybe worth a comment and/or TODO to remove?
|
It looks like there is already some discussion on the upstream PR about splitting this into a different warning flag because of the large blast radius and the desire not to disable the warning for locals. |
3 participants
llvm/llvm-project#178342 expanded the scope
of this warning, and it breaks the Emscripten library builds.