Allow REST_FRAMEWORK.PAGE_SIZE to be overriden in settings#8993
Closed
christophehenry wants to merge 1 commit intoencode:masterfrom
Closed
Allow REST_FRAMEWORK.PAGE_SIZE to be overriden in settings#8993christophehenry wants to merge 1 commit intoencode:masterfrom
christophehenry wants to merge 1 commit intoencode:masterfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Hi! Any news on reviewing this? This is a really simple PR, it should be easy to merge. |
Collaborator
|
Also this will need tests and documentation update |
Author
|
I'm not sure why the documentation should be updated. This feels like getting the intanded behaviour more than adding a feature. I'm also not sure where to put the tests for that. Can you point me to the relevant file? Would it be |
Author
|
Hi! Can I have an input here so that this may progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overriding
REST_FRAMEWORK.PAGE_SIZEwith@override_settingsin tests doesn't override setting, which is disturbing. My opinion is that there are legitimate use cases when you may want to overrideREST_FRAMEWORK.PAGE_SIZEin your tests and paginator should reflect this change.