Conversation
changed behavior of the cinematic, in order to have it well centered, and fixed a bug in which you could interact repeatedly with the sign and have the camera break out of the boundary of the map
|
Play this branch at https://play.threadbare.game/branches/endlessm/champ-sequence-puzzle-hint-sign. (This launches the game from the start, not directly at the change(s) in this pull request.) |
|
|
||
|
|
||
| func _on_hint_sign_1_demonstrate_sequence() -> void: | ||
| player._set_mode(player.Mode.DEFEATED) |
There was a problem hiding this comment.
We had talked about how it looks a little funny to have the defeated animation, particularly for this first sequence hint sign, since the player is fully visible. If we wanted to, we could replace this line with:
player._toggle_player_behavior(player.player_interaction, false)
then in the sequence completed signal (in place of line 142), we could follow up with:
player._toggle_player_behavior(player.player_interaction, true)
Not necessarily something we need to change but I wanted to leave it here as an idea. It might also be a better way to approach restricting the player's inputs when they select the wrong rock and are standing on a submerged one (before respawning). Either that, or we could leave it as DEFEATED and have the learners create an animation of the character splashing in the water or something along those lines.
There was a problem hiding this comment.
I think for now we leave it as DEFEATED for when the player select the wrong rock, as it would be a nice way to have learner find a way to create an animation that happen when something else happens (in contrast to the one animation of champ that is at the end of the level, that happen no matter what). I have however implemented the change of behavior of sign when interacted with, with the solution you have suggested.
| camera.offset.y = camera.offset.y + CAMERA_OFFSET_Y | ||
| camera.zoom.y = camera.zoom.y + CAMERA_ZOOM_SCALAR | ||
| camera.zoom.x = camera.zoom.x + CAMERA_ZOOM_SCALAR | ||
| #if _current_step == 1: |
There was a problem hiding this comment.
| #if _current_step == 1: |
Interaction are now restricted, instead of the player being defeated
2 participants
Addresses Issue #1868 and part of feedback on #1805 pull request for camera behavior