Skip to content

fix: download-all returns error on partial failures #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hinne1 merged 3 commits into from
Apr 14, 2026
Merged

fix: download-all returns error on partial failures #50

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a69a57
fix: return error from --download-all when downloads fail
Hinne1 Apr 13, 2026
94cdf73
fix: also return error in JSON output path
Hinne1 Apr 13, 2026
1354479
Merge branch 'main' into claude/fix-download-all-exit-code
Hinne1 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion internal/cmd/confluence/page/attachment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,13 @@ func downloadAllAttachments(opts *AttachmentOptions, confluence *api.ConfluenceS
Downloads: downloads,
Errors: errors,
}
return output.JSON(opts.IO.Out, result)
if err := output.JSON(opts.IO.Out, result); err != nil {
return err
}
if len(errors) > 0 {
return fmt.Errorf("failed to download %d attachment(s)", len(errors))
}
return nil
}

if len(errors) > 0 {
Expand All @@ -324,6 +330,9 @@ func downloadAllAttachments(opts *AttachmentOptions, confluence *api.ConfluenceS
}

fmt.Fprintf(opts.IO.Out, "\nDownloaded %d of %d attachments to %s\n", len(downloads), len(attachments), opts.OutputDir)
if len(errors) > 0 {
return fmt.Errorf("failed to download %d attachment(s)", len(errors))
}
Comment thread
Hinne1 marked this conversation as resolved.
return nil
}

Expand Down
Loading