Merged
Conversation
Same proven pattern from esq-cli and atl-cli. Differences from the other CLIs: - Version ldflag path: github.com/enthus-appdev/n8n-cli/internal/cmd.version (version variable lives in internal/cmd, not main) - Only one ldflag (no commit or date injection) - Binary and formula name: n8nctl (distinct from repo name n8n-cli) - Test uses `n8nctl version` subcommand (not --version flag)
fank
force-pushed
the
claude/goreleaser-migration
branch
from
4d18bf1 to
f9564dd
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a .goreleaser.yml file to automate the release process for the n8nctl CLI, covering multi-platform builds and Homebrew formula updates. Feedback suggests exporting the version variable for linker flags to follow Go best practices and tightening the Homebrew test assertion to ensure the version output format remains consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates n8n-cli to GoReleaser — completing the rollout across all 3 Go CLIs (esq-cli validated on v1.1.3, atl-cli validated on its latest release).
n8n-cli-specific differences
esq/atln8nctl./cmd/esq/./cmd/atl./cmd/n8nctl-X main.version-X github.com/enthus-appdev/n8n-cli/internal/cmd.version--versionversionsubcommandTest plan