feat: support is_negative_hits in rate limit actions#44059
Merged
wbpcode merged 5 commits intoenvoyproxy:mainfrom Apr 9, 2026
Merged
feat: support is_negative_hits in rate limit actions#44059wbpcode merged 5 commits intoenvoyproxy:mainfrom
wbpcode merged 5 commits intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
force-pushed
the
rl_action_subtrahend
branch
from
755dce1 to
c7f6a1a
Compare
Member
|
I check the previous issue and also the API. It's weird for me to do it with rate limit filter because the rate limit works with a time window rather than a single concurrency gauge. I guess, in the design, a very large limit refresh time window will be configured to make the rate limit works like a concurrency gauge. But it still weird. Could use use the concurrency filter to do this? |
wbpcode
reviewed
Mar 30, 2026
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Then, let's continue. Some comments are added to the API. Thanks for the contribution.
Comment on lines
+2719
to
+2727
| // An optional hits subtrahend to be appended to the descriptor produced by this rate limit | ||
| // configuration. This is the inverse of ``hits_addend`` and can be used to refill previously | ||
| // consumed rate limit tokens. Only one of ``hits_addend`` or ``hits_subtrahend`` may be specified. | ||
| // | ||
| // .. note:: | ||
| // This is only supported if the rate limit action is configured in the ``typed_per_filter_config`` like | ||
| // :ref:`VirtualHost.typed_per_filter_config<envoy_v3_api_field_config.route.v3.VirtualHost.typed_per_filter_config>` or | ||
| // :ref:`Route.typed_per_filter_config<envoy_v3_api_field_config.route.v3.Route.typed_per_filter_config>`, etc. | ||
| HitsSubtrahend hits_subtrahend = 8; |
Member
There was a problem hiding this comment.
I guess rather then to add a new message for subtrahend, we can add a bool field like negative_hits_addend to indicate it's subtrahend.
Then at least we needn't to handle the one of validation and so on
Member
Author
There was a problem hiding this comment.
Going with is_negative_hits alongside value under existing hits_addend API.
rudrakhp
force-pushed
the
rl_action_subtrahend
branch
4 times, most recently
from
f4b3031 to
a183428
Compare
rudrakhp
changed the title
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
force-pushed
the
rl_action_subtrahend
branch
from
a183428 to
485b270
Compare
Member
Author
|
/retest |
Signed-off-by: code <wbphub@gmail.com>
Member
Author
|
/retest |
nshipilov
pushed a commit
to nshipilov/envoy
that referenced
this pull request
Apr 13, 2026
<!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) !!!ATTENTION!!! Please check the [use of generative AI policy](https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md?plain=1#L41). You may use generative AI only if you fully understand the code. You need to disclose this usage in the PR description to ensure transparency. --> Commit Message: feat: support is_negative_hits in rate limit actions Additional Description: Support `is_negative_hits` for `hits_addend` in rate limit actions that can be used to have an opposite effect. Can be used to refill previously consumed tokens. See issue for usecase. Risk Level: Low (new api) Testing: unit testing Docs Changes: N/A Release Notes: Yes Platform Specific Features: N/A Fixes: envoyproxy#41219 --------- Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> Signed-off-by: code <wbphub@gmail.com> Co-authored-by: code <wbphub@gmail.com> Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
<!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) !!!ATTENTION!!! Please check the [use of generative AI policy](https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md?plain=1#L41). You may use generative AI only if you fully understand the code. You need to disclose this usage in the PR description to ensure transparency. --> Commit Message: feat: support is_negative_hits in rate limit actions Additional Description: Support `is_negative_hits` for `hits_addend` in rate limit actions that can be used to have an opposite effect. Can be used to refill previously consumed tokens. See issue for usecase. Risk Level: Low (new api) Testing: unit testing Docs Changes: N/A Release Notes: Yes Platform Specific Features: N/A Fixes: envoyproxy#41219 --------- Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> Signed-off-by: code <wbphub@gmail.com> Co-authored-by: code <wbphub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: feat: support is_negative_hits in rate limit actions
Additional Description: Support
is_negative_hitsforhits_addendin rate limit actions that can be used to have an opposite effect. Can be used to refill previously consumed tokens. See issue for usecase.Risk Level: Low (new api)
Testing: unit testing
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Fixes: #41219