Conversation
There was a problem hiding this comment.
In horizons the example uses data from SNORRE_TORDIS_VIGDIS and in Surfaces the example is from Grane.
We are absolutely not allowed to use data from Equinor internal projects as examples, as they are restricted data. Even on internal repos they are not allowed, as users have differnt access levels nd must request it per country or, in the case of externals, per project. But in this case this is even more critical as this is a public repo.
Please replace the examples to use the same project as was used in the polygons notebook, VOLVE_PUBLIC - the Volve data was made public by Equinor and can safely be used.
Additionally, in the horizon plot, it seems the x and y axis start at 0, instead of representing the actual coordinates? That may be confusing to the user, as they are expecting to see the actual x and y values. Is it possible to plot with the real coordinates, as in the polygons and surfaces notebooks?
|
Changed the project, but does not exist any data for the horizon schema for VOLVE_PUBLIC |
There was a problem hiding this comment.
If the code hasn't been changed in the polygons file, please remove this change from this PR.
| "id": "a175788c", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "We need to specify the name of the model we plan to use, as the `dsis-client` library requires this when building the `DSISConfig` object." |
There was a problem hiding this comment.
[Applies to both horizon and surface notebook]
I think this is an artifact from the previous version of my polygons example. This is no longer true, the model name is not necessary for DSISConfig, and it can be provided in the QueryBuilder section to avoid confusion.
| "id": "9c3feab2", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "### Fetch bulk (binary) data\n", |
There was a problem hiding this comment.
[Applies to both horizon and surface notebook]
We should demonstrate how to get the full binary file with the two methods before proceeding to visualization part.
It might be that since the visualization requires transforming the data and calculating additional information, it does not belong to the dsis-client library. It at least should be tested and compared with the transformations implemented in our current code/pipelines.
| "id": "16aafced", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "#### Method 2: `get_bulk_data_stream()` — stream in chunks\n", |
There was a problem hiding this comment.
Can this be wrapped into a library method that optionally takes input from the user regarding the chunk size, but other than that just downloads in chunks and appends them and outputs the full file if this is what the end user expects as a final result?
There was a problem hiding this comment.
The chunk_size is already optional from the user in the api, will look into the possibility of appending to a full file for final result.
3 participants
Added couple of new notebooks with example of use
Documentation improvements:
Examplessection in themkdocs.ymlnavigation.