Skip to content

cl/gossip: pass registration conditions to validators#20578

Open
LarryArnault45 wants to merge 1 commit intoerigontech:mainfrom
LarryArnault45:gossip-validator-conditions
Open

cl/gossip: pass registration conditions to validators#20578
LarryArnault45 wants to merge 1 commit intoerigontech:mainfrom
LarryArnault45:gossip-validator-conditions

Conversation

@LarryArnault45
Copy link
Copy Markdown
Contributor

@LarryArnault45 LarryArnault45 commented Apr 15, 2026

Summary

  • Pass ConditionFuncs from registerGossipService into newPubsubValidator so waitReady, rate limiting, and version gating run in the installed pubsub validator
  • Add a regression test that registers a service with a failing condition and verifies the registered validator returns ValidationIgnore before decode/process

Test plan

  • go test ./cl/phase1/network/gossip -run 'TestGossipManager/TestRegisterGossipService_PropagatesConditionsToValidator'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant