cmd/utils: fix flag deduplication in appFlags#20579
Merged
AskAlexSharov merged 1 commit intoerigontech:mainfrom Apr 15, 2026
Merged
cmd/utils: fix flag deduplication in appFlags#20579AskAlexSharov merged 1 commit intoerigontech:mainfrom
AskAlexSharov merged 1 commit intoerigontech:mainfrom
Conversation
AskAlexSharov
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes appFlags de-duplication so duplicate CLI flags are actually filtered out when composing the final *cli.App flag list.
Changes:
- Populate the
seenmap during iteration so duplicates are removed as intended.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix appFlags to actually populate the seen map, so duplicate flags are removed as intended.