Fix SQL dumps on mirroring passive servers from FinOps collectors#537
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 12, 2026
Merged
Fix SQL dumps on mirroring passive servers from FinOps collectors#537erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
The database_size_stats and server_properties collectors iterate databases with cursor-based dynamic SQL. On mirroring passive servers, RESTORING databases must be excluded to prevent severity 22 engine crashes (same root cause as #384 and #430). - database_size_stats: Change state_desc filter to d.state = 0 - server_properties: Change state_desc filter to d.state = 0, add HAS_DBACCESS() check (was missing entirely) Fixes #535 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state_desc = N'ONLINE'tod.state = 0filter to match the pattern from [BUG] SQL 2016 in single DB in mirroring setup #384/[BUG] SQL 2016 Passive Mirror Server - Still Happening #430 fixstate_desc = N'ONLINE'tod.state = 0filter, add missingHAS_DBACCESS(d.name) = 1check — this collector was iterating into databases it couldn't access on mirroring passive servers, triggering severity 22 engine crashesTest plan
Fixes #535
🤖 Generated with Claude Code