Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #81
Which component(s) does this affect?
How was this tested?
Same steps as #81 and confirmed it works.
The problem
The RaiseEvent(new RoutedEventArgs(Button.ClickEvent)) approach is unreliable in Avalonia — Button.ClickEvent is a bubble-routing event that relies on the visual tree. Calling it programmatically on a button doesn't guarantee the Click handler fires in all scenarios.
The fix extracts the advice logic into showHumanAdvice and showRobotAdvice action delegates, then uses them from both the toolbar button click handlers and the context menu event subscriptions.
Previously, humanBtn.RaiseEvent(new RoutedEventArgs(Button.ClickEvent)) was used as an indirect bridge — but Avalonia's Button.ClickEvent is a bubble-routed event tied to pointer interactions, and calling RaiseEvent programmatically on a button doesn't reliably trigger its Click handler outside of normal UI interaction. Calling the shared action directly avoids that indirection entirely.
Checklist
dotnet build -c Debug)dotnet test)