Docs: Add missing connector properties for Postgres, Iceberg#2814
Merged
Docs: Add missing connector properties for Postgres, Iceberg#2814
Conversation
|
Comment on lines
+97
to
+98
| | `/credentials/azure_client_id` | Azure Client ID | Azure App Registration Client ID for Azure Active Directory authentication. | string | Required for `AzureIAM` auth | | ||
| | `/credentials/azure_tenant_id` | Azure Tenant ID | Azure Tenant ID for Azure Active Directory authentication. | string | Required for `AzureIAM` auth | |
Contributor
There was a problem hiding this comment.
When using a cloud variant of a connector, I think we don't want to show the credential options from other clouds. This probably should get fixed in the connector.
Collaborator
Author
There was a problem hiding this comment.
That's kind of what I suspected; thanks for confirming! I updated the docs for cloud variants.
danielnelson
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Brings a few connector docs up-to-date with their current spec options, adding in properties like IAM credential options and missing advanced settings. This update focuses on these connectors:
Documentation links affected:
Connector reference docs
Notes for reviewers:
I wasn't sure if it made sense to include all IAM options for all the Postgres variants. Including all options currently matches what the user experiences in the UI.