Phase 2: Invite links UI to call GQL by GregorShear · Pull Request #1921 · estuary/ui

GregorShear · 2026-03-11T03:45:46Z

Migrate invite links from PostgREST/directives to GraphQL
Simplify invite link table in Add Users dialog
Auto-accept invites (no "click-to-accept" step)

Verify:

end-to-end invite flow works through the UI, old directive path is no longer called

kiahna-tucker

Releasing review comments while manual testing is underway.

Given the Active Invite Links table no longer has selectable rows, please remove all remaining instances of SelectTableStoreNames.ACCESS_GRANTS_LINKS. At least one instance exists within the codebase given src/context/Zustand/invariableStores.ts is not in the change list.

kiahna-tucker · 2026-03-25T16:45:33Z

+            if (error.networkError) {
+                setTableState({ status: TableStatuses.NETWORK_FAILED });
+            } else {
+                setTableState({ status: TableStatuses.TECHNICAL_DIFFICULTIES });
+            }


This syntax can be consolidated:

setTableState({ status: error.networkError ? TableStatuses.NETWORK_FAILED : TableStatuses.TECHNICAL_DIFFICULTIES });

travjenkins · 2026-03-26T15:48:20Z

+                            createInviteLink(_result, _args, cache) {
+                                invalidateQuery(cache, 'inviteLinks');
+                            },
+                            deleteInviteLink(_result, _args, cache) {
+                                invalidateQuery(cache, 'inviteLinks');
+                            },


I am assuming (hoping) that was only have to manually manage this currently since we are not using the GraphCache right now?

Did some more reading and this is not true. Oh well.

travjenkins

some changes needed

* wip * feedback

travjenkins · 2026-03-30T16:33:14Z

I tried testing with an incorrect backend (which is how I found this)

Looks like when there is an issue fetching data the error message is wrong or we are missing an alert at the top of the modal.

travjenkins

1 small change to add a new LR event. Working on testing now.

GregorShear · 2026-03-30T18:57:35Z

Now showing the error up top to agree with the table states... (network error show here, but would also apply to technical-difficulty error state)

travjenkins · 2026-03-30T20:47:09Z

+                    {hasData ? (
+                        <TableFooter>
+                            <TableRow>
+                                <TablePagination


Had video call - but adding this comment so we have a history.

Pagination is a bit messed up when you have multiple pages and click back. The first time the page updates but the data in the table does not.

There is another issue - might be related.

If you block the gql endpoint and click through pagination it is not clear that no data was sent back. If that happens the "network issue" should show up on the tabe.

travjenkins

lgtm

made the changes

GregorShear changed the title ~~invite links use gql now~~ invite links self review Mar 11, 2026

GregorShear force-pushed the greg/invites2 branch 4 times, most recently from fbd9d95 to 4ef535a Compare March 13, 2026 03:20

GregorShear changed the title ~~invite links self review~~ Phase 2: Invite links use GQL [self review] Mar 16, 2026

GregorShear changed the title ~~Phase 2: Invite links use GQL [self review]~~ Phase 2: Invite links UI to call GQL [self review] Mar 16, 2026

GregorShear force-pushed the greg/invites2 branch 5 times, most recently from c6cfc0e to 960a7b9 Compare March 20, 2026 19:02

GregorShear mentioned this pull request Mar 20, 2026

fix codegen config #1934

Merged

GregorShear force-pushed the greg/invites2 branch from 960a7b9 to 0ad3331 Compare March 21, 2026 01:58

GregorShear changed the base branch from main to greg/rm-stale-schema March 21, 2026 04:13

GregorShear force-pushed the greg/invites2 branch from 91846c8 to 64def18 Compare March 21, 2026 22:37

GregorShear force-pushed the greg/rm-stale-schema branch from 4d8ccc6 to 802db91 Compare March 23, 2026 15:17

Base automatically changed from greg/rm-stale-schema to main March 23, 2026 15:27

GregorShear force-pushed the greg/invites2 branch 2 times, most recently from 4003bff to 401a159 Compare March 23, 2026 18:12

GregorShear changed the title ~~Phase 2: Invite links UI to call GQL [self review]~~ Phase 2: Invite links UI to call GQL Mar 23, 2026

GregorShear marked this pull request as ready for review March 23, 2026 18:37

GregorShear requested a review from a team as a code owner March 23, 2026 18:37

GregorShear requested review from kiahna-tucker and travjenkins March 23, 2026 18:44

kiahna-tucker previously requested changes Mar 25, 2026

View reviewed changes

GregorShear added 4 commits March 25, 2026 23:21

squash invite stuff

219bb43

clean up invite links table

0a22cac

use mutation vals

a96cbaf

update gql codegen, remove urql cache key

e9e4864

travjenkins reviewed Mar 26, 2026

View reviewed changes

Comment thread src/components/tables/AccessGrants/AccessLinks/index.tsx Outdated

travjenkins reviewed Mar 26, 2026

View reviewed changes

Comment thread src/app/guards/GrantGuard/RedeemInviteLink.tsx Outdated

travjenkins reviewed Mar 26, 2026

View reviewed changes

GregorShear added 2 commits March 27, 2026 17:56

pr feedback

ddd6098

pr feedback

875bea6

GregorShear commented Mar 28, 2026

View reviewed changes

Comment thread src/components/inputs/PrefixedName/PrefixSelector.tsx

GregorShear added 3 commits March 27, 2026 21:36

pr feedback

a1000f6

linting

4b9af06

Phase 4b: Invites redirect to SSO login (#1933)

96bb030

* wip * feedback

put back deleted prop

f67347e

travjenkins reviewed Mar 30, 2026

View reviewed changes

Comment thread src/components/login/SSO/useSSOSignIn.ts

travjenkins reviewed Mar 30, 2026

View reviewed changes

GregorShear added 2 commits March 30, 2026 13:46

add LR event

44d6339

set error

0e12f06

linting

d6ed342

GregorShear added the change:planned This is a planned change label Mar 30, 2026

travjenkins reviewed Mar 30, 2026

View reviewed changes

Comment thread src/components/tables/AccessGrants/AccessLinks/Row.tsx Outdated

delete button

d3efbb9

travjenkins reviewed Mar 30, 2026

View reviewed changes

fix off-by-one pagination bug

923afd8

travjenkins requested review from kiahna-tucker and travjenkins March 31, 2026 14:44

travjenkins approved these changes Mar 31, 2026

View reviewed changes

Merge branch 'main' into greg/invites2

1189c97

GregorShear merged commit eac2f05 into main Mar 31, 2026
6 checks passed

GregorShear deleted the greg/invites2 branch March 31, 2026 15:11

Conversation

GregorShear commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kiahna-tucker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kiahna-tucker Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

travjenkins Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

travjenkins Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

travjenkins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

travjenkins commented Mar 30, 2026

Uh oh!

Uh oh!

travjenkins left a comment

Choose a reason for hiding this comment

Uh oh!

GregorShear commented Mar 30, 2026

Uh oh!

Uh oh!

travjenkins Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

travjenkins Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

travjenkins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GregorShear commented Mar 11, 2026 •

edited

Loading