refactor: Enhance ClaimStEthWithdrawals script#373
Open
pankajjagtapp wants to merge 6 commits intomasterfrom
Open
refactor: Enhance ClaimStEthWithdrawals script#373pankajjagtapp wants to merge 6 commits intomasterfrom
pankajjagtapp wants to merge 6 commits intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d9c0efc64
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
📊 Forge Coverage ReportGenerated by workflow run #668 |
…ubmission handling for operators on mainnet forks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
… for improved request ID sorting
… and operator submission resets
…e pending EigenLayer stETH withdrawals
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Commented-out operation code left in new script
- Removed the commented-out stEthRequestWithdrawal testing code that was leftover from development and unrelated to the script's purpose of completing queued withdrawals.
Or push these changes by commenting:
@cursor push 1fd9681de6
Preview (1fd9681de6)
diff --git a/script/operations/steth-management/CompleteQueuedWithdrawalsStETH.s.sol b/script/operations/steth-management/CompleteQueuedWithdrawalsStETH.s.sol
--- a/script/operations/steth-management/CompleteQueuedWithdrawalsStETH.s.sol
+++ b/script/operations/steth-management/CompleteQueuedWithdrawalsStETH.s.sol
@@ -97,17 +97,5 @@
console2.log("Remaining pending roots:", etherFiRestaker.pendingWithdrawalRoots().length);
console2.log("Remaining restaked stETH:", etherFiRestaker.getRestakedAmount(lido));
console2.log("Simulation successful");
-
- // bytes memory callData2 = abi.encodeWithSignature(
- // "stEthRequestWithdrawal(uint256)",
- // 50000 ether
- // );
- // console2.log("");
- // console2.log("=== stEthRequestWithdrawal calldata ===");
- // console2.log("Target:", address(etherFiRestaker));
- // console2.logBytes(callData2);
-
- // vm.prank(ETHERFI_OPERATING_ADMIN);
- // etherFiRestaker.stEthRequestWithdrawal(50000 ether);
}
}…hdrawal command execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Operational scripts now auto-discover claimable Lido requests and add a new helper to complete EigenLayer queued stETH withdrawals; logic is off-chain but could change how admins generate/simulate calldata. Test changes alter assertions and fork state setup, which may affect test expectations but not production contracts.
Overview
Improves stETH ops scripts under
script/operations/steth-managementby updating command paths, enhancingClaimStEthWithdrawalsto auto-fetch, filter (finalized & unclaimed), sort, and generate/simulate calldata for all restaker-owned Lido withdrawal requests, and addingCompleteQueuedWithdrawalsStETHto build calldata and simulate completing EigenLayer queued stETH withdrawals once past the minimum delay.Tightens fork integration tests:
Handle-Remainder-Shares.t.solswitches the treasury split check from balance deltas to share deltas to avoid rounding noise, andValidator-Flows.t.sol/Withdraw.t.solnow reset oracle committee member submission state (remove + re-add operators) in setup to prevent mainnet-fork stale-submission failures.Written by Cursor Bugbot for commit 2851bd0. This will update automatically on new commits. Configure here.