feat: add support for stateful fixture format#182
Draft
fselmo wants to merge 2 commits intoethpandaops:masterfrom
Draft
feat: add support for stateful fixture format#182fselmo wants to merge 2 commits intoethpandaops:masterfrom
fselmo wants to merge 2 commits intoethpandaops:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes go together with the execution-specs PR here. I will leave this as a draft until the design / approach is settled there as some of this flow may change. The main goal here is to be able to read the pre-run file, apply these things before setting the checkpoint, and then be able to read the new stateful fixture format and run these tests with benchmarkoor.
The current state of this flow has been tested and is working but some of these interactions may change, as mentioned above. I will mark when this is ready for a final review.
bonus: fix CI hard-coded paths to allow running checks on PRs from personal forks of benchmarkoor - commit here