ENG-3275: Display named OAuth clients#7869
Draft
tvandort wants to merge 7 commits intoENG-3001-ui-scope-pickerfrom
Draft
ENG-3275: Display named OAuth clients#7869tvandort wants to merge 7 commits intoENG-3001-ui-scope-pickerfrom
tvandort wants to merge 7 commits intoENG-3001-ui-scope-pickerfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
tvandort
force-pushed
the
ENG-3001-ui-scope-picker
branch
from
960be34 to
ac17689
Compare
Add client_id field to RequestContext with get_client_id/set_client_id helpers. Update both sync and async extract_token_and_load_client() to call set_client_id() when the authenticated actor is a non-user-linked API client (no user_id, not root). Previously these requests left the context empty, making attribution impossible. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- test_request_context.py: unit tests for get/set_client_id, isolation from user_id/request_id, and reset behavior - conftest.py: add request_context_client_id fixture alongside the existing request_context_user_id fixture - test_request_context_population.py: tests for the actor-type branching logic (user-linked client → user_id, API client → client_id, root client → user_id set to root_client_id) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ttachmentService EventAuditService.create_event_audit() gains an explicit client_id kwarg and falls back to get_client_id() from request context, mirroring the existing user_id / get_user_id() pattern. AttachmentService.create_and_upload() injects client_id from request context into the data dict if the caller hasn't already set it, so API client uploads are attributed without changing every call site. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Introduces AttributionService with get_actor_display_name() to resolve human-readable display names from either user_id or client_id, ready for use in fidesplus attribution stories. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds client_id to generated CommentResponse, AttachmentResponse, and EventAuditResponse types. TaxonomyHistory falls back to client_id when user_id is absent so API client actions are attributed correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (98.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## ENG-3001-ui-scope-picker #7869 +/- ##
===========================================================
Coverage ? 85.10%
===========================================================
Files ? 628
Lines ? 40817
Branches ? 4745
===========================================================
Hits ? 34736
Misses ? 5013
Partials ? 1068 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deduplicates the identical actor-attribution logic that appeared in both the sync and async token extraction paths. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-3275
Description Of Changes
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works