Skip to content

ENG-3324: Monitor steward inheritance data model#7888

Draft
adamsachs wants to merge 1 commit intomainfrom
ENG-3324/monitor-steward-inheritance
Draft

ENG-3324: Monitor steward inheritance data model#7888
adamsachs wants to merge 1 commit intomainfrom
ENG-3324/monitor-steward-inheritance

Conversation

@adamsachs
Copy link
Copy Markdown
Contributor

@adamsachs adamsachs commented Apr 10, 2026

Ticket ENG-3324

Description Of Changes

First step toward monitor stewardship inheritance. Adds data model support so that monitors can inherit stewards from their linked system(s) via sync.

Companion PR in fidesplus adds the API/schema layer. The background sync job that populates inherited rows is a separate ticket.

Code Changes

  • Add inherit_system_stewards boolean column to MonitorConfig (default true for new monitors, backfilled false for existing)
  • Extend MonitorSteward with source column (explicit/inherited, default explicit) and nullable source_system_id FK to ctl_systems
  • Update unique constraint on monitorsteward from (user_id, monitor_config_id) to (user_id, monitor_config_id, source) — allows the same user to exist as both explicit and inherited
  • Alembic migration with clean upgrade/downgrade (downgrade deletes inherited rows before restoring old constraint)

Steps to Confirm

  1. Apply migration: verify monitorconfig.inherit_system_stewards column exists, existing rows have false, new inserts default to true
  2. Verify monitorsteward table has source and source_system_id columns
  3. Verify unique constraint allows same (user_id, monitor_config_id) pair with different source values
  4. Run downgrade: verify inherited rows are cleaned up and old constraint is restored

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Optional: Follow-Up Issues Created

🤖 Generated with Claude Code

Add inherit_system_stewards boolean to MonitorConfig (default true,
backfilled false for existing monitors). Extend MonitorSteward with
source column (explicit/inherited) and source_system_id FK so inherited
steward rows can coexist with explicit ones.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Apr 10, 2026 1:17am
fides-privacy-center Ignored Ignored Apr 10, 2026 1:17am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant