ENG-3324: Monitor steward inheritance data model#7888
Draft
Conversation
Add inherit_system_stewards boolean to MonitorConfig (default true, backfilled false for existing monitors). Extend MonitorSteward with source column (explicit/inherited) and source_system_id FK so inherited steward rows can coexist with explicit ones. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3324
Description Of Changes
First step toward monitor stewardship inheritance. Adds data model support so that monitors can inherit stewards from their linked system(s) via sync.
Companion PR in fidesplus adds the API/schema layer. The background sync job that populates inherited rows is a separate ticket.
Code Changes
inherit_system_stewardsboolean column toMonitorConfig(defaulttruefor new monitors, backfilledfalsefor existing)MonitorStewardwithsourcecolumn (explicit/inherited, defaultexplicit) and nullablesource_system_idFK toctl_systemsmonitorstewardfrom(user_id, monitor_config_id)to(user_id, monitor_config_id, source)— allows the same user to exist as both explicit and inheritedSteps to Confirm
monitorconfig.inherit_system_stewardscolumn exists, existing rows havefalse, new inserts default totruemonitorstewardtable hassourceandsource_system_idcolumns(user_id, monitor_config_id)pair with differentsourcevaluesPre-Merge Checklist
🤖 Generated with Claude Code