ENG-3386: system-template badge + sectioned popover for standard reports#7910
Draft
ENG-3386: system-template badge + sectioned popover for standard reports#7910
Conversation
Splits the datamap custom-reports popover into 'Standard templates' and 'Your reports' sections when ICO/DPC/CNIL (or any future system-seeded) templates are present, with a 'Standard' tag and a suppressed delete affordance on system-owned rows. Falls back to the prior flat layout when only user reports exist. Extends the generated CustomReportResponseMinimal/CustomReportResponse types with the new optional system_template_key field surfaced by fidesplus. Hand-edited here pending a scheduled type regeneration after the fidesplus PR merges. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3386
Description Of Changes
Frontend companion to the OOTB regulatory reporting templates backend (ethyca/fidesplus#3407). When the backend seeds system-owned ICO/DPC/CNIL datamap reports, this PR surfaces them in the custom-reports popover with clear visual differentiation:
info-coloured Tag with a tooltip explaining they're out-of-the-box and cannot be deleted.DELETEcall as defense in depth.)Code Changes
clients/admin-ui/src/types/api/models/CustomReportResponseMinimal.ts— addssystem_template_key?: string | null(hand-edited pending type regeneration after fidesplus PR merge)clients/admin-ui/src/types/api/models/CustomReportResponse.ts— same field addition (inherited in the backend, hand-edited here)clients/admin-ui/src/features/common/custom-reports/CustomReportTemplates.tsx:searchResultsintosystemReports/userReportsviauseMemoRadio.GroupTag(colourinfo) +Tooltipon system-template rowsButtonfor rows withsystem_template_keyclients/admin-ui/cypress/fixtures/custom-reports/minimal-with-system-template.json— new fixture with one system and one user reportclients/admin-ui/cypress/e2e/datamap-report.cy.ts— two new tests inside the "Custom report templates" describe block:Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated🤖 Generated with Claude Code