ENG-3287: Assessment grouping by processing activity (demo)#7913
Draft
galvana wants to merge 16 commits intodemo/aprilfrom
Draft
ENG-3287: Assessment grouping by processing activity (demo)#7913galvana wants to merge 16 commits intodemo/aprilfrom
galvana wants to merge 16 commits intodemo/aprilfrom
Conversation
Change the privacy assessments list page to group by data use (processing activity) instead of regulatory template. Each group shows the processing activity name with system and assessment counts. Cards now display the template name as subtitle and system name as detail. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Simplify the list page to render groups directly from the backend response instead of computing grouping client-side. Removes the separate processing-activities query. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Breadcrumb and header now show template name instead of assessment name. System name shown as subtitle without prefix. Removed redundant "Processing ... for data_use" line since data use context is provided by the group on the list page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use nullish coalescing (??) instead of || for dataUseName fallback - Derive hasAssessments from groups.length instead of total - Add index fallback for React key on null data_use groups - Type status param as AssessmentStatus instead of string - Remove unnecessary div wrapper around system_name Text Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The merge from main on the original feature branch set AssessmentDetail
title to level={2}. Aligning the cherry-picked branch to match.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked feature commits from
ENG-3287-assessment-grouping-by-processing-activityontodemo/aprilfor a clean diff.Companion PR: fidesplus (see link below after creation)
Original PR against main: #7887