Skip to content

ENG-3422: Remove dashboard dimension click-to-filter interaction#7916

Open
kruulik wants to merge 4 commits intomainfrom
3422-dashboard-polish-2
Open

ENG-3422: Remove dashboard dimension click-to-filter interaction#7916
kruulik wants to merge 4 commits intomainfrom
3422-dashboard-polish-2

Conversation

@kruulik
Copy link
Copy Markdown
Contributor

@kruulik kruulik commented Apr 14, 2026

Ticket ENG-3422

Description Of Changes

Removes the radar chart click-to-filter interaction from the homepage dashboard. Previously, clicking a dimension on the Governance Posture radar chart would filter the Priority Actions list by that dimension. This interaction is being removed as part of Newscorp dashboard polish.

Code Changes

  • Removed handleDimensionClick callback and onDimensionClick prop from RadarChart in PostureCard.tsx
  • Removed useDimensionFilter hook usage, dimension filter tag UI, and dimension query parameter from PriorityActionsCard.tsx
  • Deleted useDimensionFilter.ts (dead code — no remaining imports)
  • Fixed Prettier formatting on import statement

Steps to Confirm

  1. Navigate to the homepage dashboard
  2. Verify the Governance Posture radar chart renders correctly
  3. Confirm clicking on radar chart dimensions does not trigger any filtering
  4. Verify the Priority Actions card loads and displays all actions without a dimension filter tag
  5. Confirm status and severity filters on Priority Actions still work

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

kruulik added 3 commits April 14, 2026 13:32
Delete useDimensionFilter.ts (no remaining imports) and fix Prettier
formatting on PriorityActionsCard.tsx import.
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 14, 2026 7:28pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 14, 2026 7:28pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.1% (2663/43647) 5.22% (1293/24744) 4.19% (542/12914)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.93% (330/384) 81.1% (176/217) 78.87% (56/71)

@kruulik kruulik marked this pull request as ready for review April 14, 2026 20:26
@kruulik kruulik requested a review from a team as a code owner April 14, 2026 20:26
@kruulik kruulik requested review from jpople and removed request for a team April 14, 2026 20:26
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: .mcp.json

This PR has one finding worth addressing before merge.

Critical: Hardcoded CI runner path committed

The command field in .mcp.json was changed from the correct shell-expansion fallback ${CODEGRAPH_SERVER_PATH:-/bin/false} to a hardcoded absolute path /opt/hostedtoolcache/Python/3.13.12/x64/bin/codegraph-server.

The existing _comment in the file documents the expected behavior: locally this falls back to /bin/false (silent no-op), while CI rewrites the field at runtime via the claude-code-review.yml workflow using which codegraph-server. The committed value is only ever a fallback sentinel — it should remain the shell-expansion form.

The hardcoded path will:

  • Not resolve on any developer machine (it's a GitHub-Actions-specific ephemeral toolcache path)
  • Break in CI as soon as the Python patch version advances beyond 3.13.12

This appears to be a side-effect of a CI debug session where the rewritten .mcp.json was accidentally staged and committed. The fix is to revert line 5 to "command": "${CODEGRAPH_SERVER_PATH:-/bin/false}".


🔬 Codegraph: connected (46711 nodes)

💡 Write /code-review in a comment to re-run this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant