ENG-3422: Remove dashboard dimension click-to-filter interaction#7916
ENG-3422: Remove dashboard dimension click-to-filter interaction#7916
Conversation
Delete useDimensionFilter.ts (no remaining imports) and fix Prettier formatting on PriorityActionsCard.tsx import.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Code Review: .mcp.json
This PR has one finding worth addressing before merge.
Critical: Hardcoded CI runner path committed
The command field in .mcp.json was changed from the correct shell-expansion fallback ${CODEGRAPH_SERVER_PATH:-/bin/false} to a hardcoded absolute path /opt/hostedtoolcache/Python/3.13.12/x64/bin/codegraph-server.
The existing _comment in the file documents the expected behavior: locally this falls back to /bin/false (silent no-op), while CI rewrites the field at runtime via the claude-code-review.yml workflow using which codegraph-server. The committed value is only ever a fallback sentinel — it should remain the shell-expansion form.
The hardcoded path will:
- Not resolve on any developer machine (it's a GitHub-Actions-specific ephemeral toolcache path)
- Break in CI as soon as the Python patch version advances beyond
3.13.12
This appears to be a side-effect of a CI debug session where the rewritten .mcp.json was accidentally staged and committed. The fix is to revert line 5 to "command": "${CODEGRAPH_SERVER_PATH:-/bin/false}".
🔬 Codegraph: connected (46711 nodes)
💡 Write /code-review in a comment to re-run this review.
Ticket ENG-3422
Description Of Changes
Removes the radar chart click-to-filter interaction from the homepage dashboard. Previously, clicking a dimension on the Governance Posture radar chart would filter the Priority Actions list by that dimension. This interaction is being removed as part of Newscorp dashboard polish.
Code Changes
handleDimensionClickcallback andonDimensionClickprop fromRadarChartinPostureCard.tsxuseDimensionFilterhook usage, dimension filter tag UI, anddimensionquery parameter fromPriorityActionsCard.tsxuseDimensionFilter.ts(dead code — no remaining imports)Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works