Skip to content

ENG-3329: Add property info to privacy request details panel#7930

Draft
jpople wants to merge 2 commits intomainfrom
jpople/eng-3329/property-info-on-request-details
Draft

ENG-3329: Add property info to privacy request details panel#7930
jpople wants to merge 2 commits intomainfrom
jpople/eng-3329/property-info-on-request-details

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Apr 15, 2026

Ticket ENG-3329

Description Of Changes

When a privacy request is submitted with a property_id (identifying the Fides property/website it came from), that information is now surfaced in the request details panel in the admin UI.

The property_id field was already stored on the PrivacyRequest model but was not included in the API response schema. This PR adds it to PrivacyRequestResponse, which Pydantic serializes automatically via from_attributes. The fidesplus PrivacyRequestResponseExtended inherits the field with no changes required in that repo.

Code Changes

  • src/fides/api/schemas/privacy_request.py — Added property_id: Optional[str] = None to PrivacyRequestResponse. No migration needed (column already exists).
  • clients/admin-ui/src/features/privacy-requests/types.ts — Added property_id?: string | null to PrivacyRequestEntity.
  • clients/admin-ui/src/features/privacy-requests/RequestDetails.tsx — Added a conditional "Property" row below "Source". Fetches the property name via useGetPropertyByIdQuery (skipped if no property_id or no Plus). Renders the name as a link to the property edit page.
  • clients/admin-ui/src/features/privacy-requests/RequestDetails.test.tsx — New test file covering all four conditional rendering scenarios.

Steps to Confirm

  1. With a Plus-enabled instance, create a privacy request that includes a property_id (e.g. via the API or Privacy Center with a property configured).
  2. Open the request in the admin UI → the details panel should show a "Property" row with the property name, linked to its edit page.
  3. Open a request with no property_id → the "Property" row should not appear.
  4. On a non-Plus instance, no "Property" row should appear even if property_id is set.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Apr 15, 2026 6:53am
fides-privacy-center Ignored Ignored Apr 15, 2026 6:53am

Request Review

@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.12% (2674/43635) 5.29% (1310/24741) 4.22% (546/12916)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant