ENG-3329: Add property info to privacy request details panel#7930
Draft
ENG-3329: Add property info to privacy request details panel#7930
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3329
Description Of Changes
When a privacy request is submitted with a
property_id(identifying the Fides property/website it came from), that information is now surfaced in the request details panel in the admin UI.The
property_idfield was already stored on thePrivacyRequestmodel but was not included in the API response schema. This PR adds it toPrivacyRequestResponse, which Pydantic serializes automatically viafrom_attributes. The fidesplusPrivacyRequestResponseExtendedinherits the field with no changes required in that repo.Code Changes
src/fides/api/schemas/privacy_request.py— Addedproperty_id: Optional[str] = NonetoPrivacyRequestResponse. No migration needed (column already exists).clients/admin-ui/src/features/privacy-requests/types.ts— Addedproperty_id?: string | nulltoPrivacyRequestEntity.clients/admin-ui/src/features/privacy-requests/RequestDetails.tsx— Added a conditional "Property" row below "Source". Fetches the property name viauseGetPropertyByIdQuery(skipped if noproperty_idor no Plus). Renders the name as a link to the property edit page.clients/admin-ui/src/features/privacy-requests/RequestDetails.test.tsx— New test file covering all four conditional rendering scenarios.Steps to Confirm
property_id(e.g. via the API or Privacy Center with a property configured).property_id→ the "Property" row should not appear.property_idis set.Pre-Merge Checklist
CHANGELOG.mdupdated