Reword "click here" links for accessibility#7937
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
There was a problem hiding this comment.
Code Review
Good accessibility improvement — replacing generic "click here" link text with descriptive text benefits screen reader users and improves SEO. The changes are consistent across admin UI, docs, and email templates.
Bug (should fix)
password_reset.html: The closing </p> tag was dropped from the first paragraph when restructuring the link. Left as-is, the paragraph is unclosed. Email client rendering can be unpredictable with malformed HTML, so this should be restored.
Nit
docs/fides/overrides/main.html: The only needed change was the link text, but the file was also reformatted — {% extends %}, {% block %}, and the text content were collapsed onto the same lines. This makes the template harder to read without adding value. Worth reverting the formatting to match what it was before (or what 404.html looks like).
Looks Good
GVLNotice.tsx: Clean fix; "More information on the Global Vendor List." is clear and self-describing as link text.404.html: Correct minimal change — only the link text updated, formatting preserved.user_invite.html: "accept the invite" reads naturally in context.password_reset.htmllink text: "reset your Fides account password" is descriptive and contextual.- Test in
message_dispatch_service_test.pyis correctly updated to match the new template output. - Changelog entry is present and accurate.
🔬 Codegraph: connected (46727 nodes)
💡 Write /code-review in a comment to re-run this review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7937 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 629 629
Lines 40860 40860
Branches 4748 4748
=======================================
Hits 34759 34759
Misses 5029 5029
Partials 1072 1072 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ticket [N/A]
Description Of Changes
Removes the "click here" anti-pattern from link text across the admin UI, docs overrides, and email templates. Link text should describe the destination rather than the action, both for accessibility (screen reader users navigating by link list) and general UX.
Code Changes
clients/admin-ui/src/features/system/GVLNotice.tsx: GVL info link rewordeddocs/fides/overrides/404.html: latest-stable-version link rewordeddocs/fides/overrides/main.html: latest-stable-version link reworded in outdated-version bannersrc/fides/api/email_templates/templates/password_reset.html: reset-password link rewordedsrc/fides/api/email_templates/templates/user_invite.html: accept-invite link rewordedtests/ops/service/messaging/message_dispatch_service_test.py: updated expected email body to match new templateSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works