Skip to content

Reword "click here" links for accessibility#7937

Open
gilluminate wants to merge 3 commits intomainfrom
gill/no-click-here
Open

Reword "click here" links for accessibility#7937
gilluminate wants to merge 3 commits intomainfrom
gill/no-click-here

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

Ticket [N/A]

Description Of Changes

Removes the "click here" anti-pattern from link text across the admin UI, docs overrides, and email templates. Link text should describe the destination rather than the action, both for accessibility (screen reader users navigating by link list) and general UX.

Code Changes

  • clients/admin-ui/src/features/system/GVLNotice.tsx: GVL info link reworded
  • docs/fides/overrides/404.html: latest-stable-version link reworded
  • docs/fides/overrides/main.html: latest-stable-version link reworded in outdated-version banner
  • src/fides/api/email_templates/templates/password_reset.html: reset-password link reworded
  • src/fides/api/email_templates/templates/user_invite.html: accept-invite link reworded
  • tests/ops/service/messaging/message_dispatch_service_test.py: updated expected email body to match new template

Steps to Confirm

  1. Trigger a password reset email in a local env and confirm the link text reads "reset your Fides account password" (no "click here")
  2. Trigger a user invite email and confirm the link text reads "accept the invite" (no "click here")
  3. Visit the outdated-docs banner / 404 page and confirm the link reads "Latest stable version"
  4. Open the GVL notice in the admin UI (System edit page, GVL vendor) and confirm the link reads "More information on the Global Vendor List"

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Apr 15, 2026 9:01pm
fides-privacy-center Ignored Ignored Apr 15, 2026 9:01pm

Request Review

@gilluminate gilluminate requested a review from erosselli April 15, 2026 20:48
@gilluminate gilluminate marked this pull request as ready for review April 15, 2026 20:49
@gilluminate gilluminate requested review from a team as code owners April 15, 2026 20:49
@gilluminate gilluminate requested review from lucanovera and removed request for a team April 15, 2026 20:49
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Good accessibility improvement — replacing generic "click here" link text with descriptive text benefits screen reader users and improves SEO. The changes are consistent across admin UI, docs, and email templates.

Bug (should fix)

password_reset.html: The closing </p> tag was dropped from the first paragraph when restructuring the link. Left as-is, the paragraph is unclosed. Email client rendering can be unpredictable with malformed HTML, so this should be restored.

Nit

docs/fides/overrides/main.html: The only needed change was the link text, but the file was also reformatted — {% extends %}, {% block %}, and the text content were collapsed onto the same lines. This makes the template harder to read without adding value. Worth reverting the formatting to match what it was before (or what 404.html looks like).

Looks Good

  • GVLNotice.tsx: Clean fix; "More information on the Global Vendor List." is clear and self-describing as link text.
  • 404.html: Correct minimal change — only the link text updated, formatting preserved.
  • user_invite.html: "accept the invite" reads naturally in context.
  • password_reset.html link text: "reset your Fides account password" is descriptive and contextual.
  • Test in message_dispatch_service_test.py is correctly updated to match the new template output.
  • Changelog entry is present and accurate.

🔬 Codegraph: connected (46727 nodes)


💡 Write /code-review in a comment to re-run this review.

Comment thread src/fides/api/email_templates/templates/password_reset.html Outdated
Comment thread docs/fides/overrides/main.html
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.1% (2663/43634) 5.22% (1293/24740) 4.19% (542/12914)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.06%. Comparing base (c6fe17d) to head (c05c1ee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7937   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         629      629           
  Lines       40860    40860           
  Branches     4748     4748           
=======================================
  Hits        34759    34759           
  Misses       5029     5029           
  Partials     1072     1072           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant