Conversation
[docs] Fix broken links in README.md
* upgrade modules * no vendor * update tests * update e2e * go mod tidy * bump go * update k8s client * canonical bcr name for rules_go and gazelle * upgrade protobuf * fix e2e * cleanup * upgrade k8s client
Signed-off-by: Vincent Composieux <vincent@composieux.fr>
…terci#63) * fix: export RUNFILES_DIR for child bash scripts Add RUNFILES_DIR=${RUNFILES} to async function so that child bash scripts (like .push scripts) can find runfiles.bash. Without this, child scripts fail with "runfiles.bash initializer cannot find bazel_tools/tools/bash/runfiles/runfiles.bash" error. The issue occurs because: - Parent scripts only export PYTHON_RUNFILES (Python-specific) - Child bash scripts check RUNFILES_DIR environment variable - Without RUNFILES_DIR, runfiles.bash initialization fails * fix: export RUNFILES_DIR in k8s_gitops.sh.tpl for k8s_deploy Add RUNFILES_DIR=${RUNFILES} to async function in k8s_gitops.sh.tpl. This template is used by k8s_deploy.apply (not k8s_test_namespace.sh.tpl which is for tests only). * fix: export RUNFILES_DIR in kubectl.sh.tpl for k8s_deploy.apply Add RUNFILES_DIR=${RUNFILES} to async function in kubectl.sh.tpl. This is the actual template used by the kubectl rule which generates the k8s_deploy.apply target.
Bring all Etsy-specific customizations onto the latest upstream/main,
which includes Bazel 8 upgrade, bazel_flag support, .diff target,
RUNFILES_DIR fix, protobuf migration, and release prep.
Etsy changes ported:
- GitHub App support (github_app package, CreateCommit/CreatePR)
- go-github v32 → v68, added ghinstallation/v2
- Buildkite CI integration (env vars, branch naming)
- Optional namespace in k8s/kustomize rules
- respect_resource_namespace parameter
- app_name for gitops directory structure
- Image resolver enhancements (resolveImageName, updateContainerEnv)
- push_oci external image fix
- Deploy GitHub Actions workflow
Upstream features preserved:
- deploy_branch_prefix configurability
- bazel_flag passthrough
- BazelCmd usage in cquery
- CloneOrCheckout with branch prefix
- "${@}" argument passthrough in template
- google.golang.org/protobuf (not golang/protobuf)
- errgroup for parallel push
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a5f26eda5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bkRepo = strings.Replace(bkRepo, "git@", "https://", 1) | ||
| bkRepo = strings.Replace(bkRepo, ".git", "", 1) | ||
| commit := fmt.Sprintf("%s/commit/%s", bkRepo, sha) | ||
| shortSha := sha[:7] |
There was a problem hiding this comment.
This slices BUILDKITE_COMMIT unconditionally, so running create_gitops_prs outside Buildkite (or with a missing/short BUILDKITE_COMMIT) panics with slice bounds out of range before any push/PR logic runs. The script already passes --git_commit, but this code ignores it for title generation, making non-Buildkite executions fail at runtime.
Useful? React with 👍 / 👎.
| if strings.HasPrefix(envValue, "//") { | ||
| kv["value"] = pt.images[envValue] | ||
| } | ||
| if strings.HasPrefix(envValue, ":") { | ||
| kv["value"] = pt.images[envValue[1:]] |
There was a problem hiding this comment.
These assignments write directly from the map without checking key existence, so an env value like //foo or :foo that is not present in pt.images is silently replaced with an empty string instead of being preserved or rejected. That can generate manifests with empty image URL env vars and break workloads at deploy/runtime.
Useful? React with 👍 / 👎.
| ref, _, err := gh.Git.CreateRef(ctx, *repoOwner, *repo, newRef) | ||
| if err != nil { | ||
| log.Fatalf("failed to create branch ref: %v", err) |
There was a problem hiding this comment.
This path always calls CreateRef and fatals on any error, so rerunning a deployment for the same branch name (which the wrapper derives from commit SHA prefix) fails with a 422 "Reference already exists" instead of updating/reusing the branch. That makes retries non-idempotent in the github_app flow.
Useful? React with 👍 / 👎.
7 participants
Bring all Etsy-specific customizations onto the latest upstream/main, which includes Bazel 8 upgrade, bazel_flag support, .diff target, RUNFILES_DIR fix, protobuf migration, and release prep.
Etsy changes ported:
Upstream features preserved: