Open
Conversation
theangrydev
requested changes
Feb 11, 2026
Collaborator
theangrydev
left a comment
theangrydev
left a comment
There was a problem hiding this comment.
Most of these tests have no assertions and so aren't proving the behaviour under test
testing-modules/testng-2/src/test/java/com/baeldung/testng/DataDrivenNameTest.java
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByReflectionTest.java
Outdated
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByResultTest.java
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByXmlSuite.java
Outdated
Show resolved
Hide resolved
theangrydev
requested changes
Feb 16, 2026
testing-modules/testng-2/src/test/java/com/baeldung/testng/DataDrivenNameTest.java
Outdated
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/DataDrivenNameTest.java
Outdated
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/FactoryNameTest.java
Outdated
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByResultTest.java
Outdated
Show resolved
Hide resolved
theangrydev
requested changes
Mar 18, 2026
testing-modules/testng-2/src/test/java/com/baeldung/testng/DataDrivenNameTest.java
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/DataDrivenNameTest.java
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByXmlSuiteTest.java
Outdated
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByXmlSuiteTest.java
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByXmlSuiteTest.java
Show resolved
Hide resolved
|
|
||
| @Factory | ||
| public static Object[] build() { | ||
| return new Object[] { new FactoryNameTest("fast-path"), new FactoryNameTest("slow-path") }; |
Collaborator
There was a problem hiding this comment.
We have a guideline to use the Baeldung code formatter
Contributor
Author
There was a problem hiding this comment.
It's enabled on IntelliJ but doesn't want to format this line differently.
testing-modules/testng-2/src/test/java/com/baeldung/testng/FactoryNameTest.java
Outdated
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/FactoryNameTest.java
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByReflectionTest.java
Outdated
Show resolved
Hide resolved
testing-modules/testng-2/src/test/java/com/baeldung/testng/NameByResultTest.java
Outdated
Show resolved
Hide resolved
theangrydev
reviewed
Mar 18, 2026
testing-modules/testng-2/src/test/java/com/baeldung/testng/FactoryNameTest.java
Outdated
Show resolved
Hide resolved
…aDrivenNameTest.java Co-authored-by: Liam Williams <liam.williams@zoho.com>
…eByXmlSuiteTest.java Co-authored-by: Liam Williams <liam.williams@zoho.com>
…aDrivenNameTest.java Co-authored-by: Liam Williams <liam.williams@zoho.com>
…toryNameTest.java Co-authored-by: Liam Williams <liam.williams@zoho.com>
…eByReflectionTest.java Co-authored-by: Liam Williams <liam.williams@zoho.com>
…eByResultTest.java Co-authored-by: Liam Williams <liam.williams@zoho.com>
…toryNameTest.java Co-authored-by: Liam Williams <liam.williams@zoho.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.