fix(security): isolate proxy env in shared runtimes#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Harden FetchKit for multi-tenant and clustered deployments by isolating proxy environment inheritance by default and documenting the security posture.
Why
Shared runtimes can carry ambient
HTTP_PROXY/HTTPS_PROXYconfiguration that silently reroutes fetch traffic through operator-provided or compromised proxies. That weakens deployment isolation and makes threat-model assumptions less reliable.How
respect_proxy_env(false)as the default tool/fetch optionreqwest::ClientBuilder::no_proxy()in built-in fetchers unless the caller opts inRisk
respect_proxy_env(true).Checklist
cargo fmt --all -- --checkpassedcargo clippy --workspace --all-targets -- -D warningspassedcargo test --workspacepassedRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-depspassed