👌 Throw an error if 3rd party plugin doesn't increment line or pos counters#336
👌 Throw an error if 3rd party plugin doesn't increment line or pos counters#336hukkin wants to merge 2 commits intoexecutablebooks:masterfrom
line or pos counters#336Conversation
|
It seems the commit message got somehow malformed when copy pasting a message with backticks to to terminal. Perhaps best to squash and merge with the PRs (or other) message. |
| ) | ||
| DIGITAL_ENTITY_BASE10_RE = re.compile(r"#([0-9]{1,8})") | ||
| DIGITAL_ENTITY_BASE16_RE = re.compile(r"#x([a-f0-9]{1,8})", re.IGNORECASE) | ||
| DIGITAL_ENTITY_TEST_RE = re.compile( |
There was a problem hiding this comment.
This change seems separate to the PR title?
Can you split it into a separate PR
There was a problem hiding this comment.
Most changes here are unrelated refactors actually. This is a port of the diff in the first post. Should something else be split too?
There was a problem hiding this comment.
Yeh ideally it should be split up fully into "logical changes" 😅
There was a problem hiding this comment.
👍 Pushed a new commit history. Would this split work?
There was a problem hiding this comment.
Would this split work?
Please split them up into separate PRs, with a clear description of their intention; the smaller the PR better, and the more likely I can just merge them without much effort/delay
hukkin
force-pushed
the
sync-upstream-commit-49ca65b
branch
from
2126aeb to
fe0e4e7
Compare
…` counters (previously infinite loop would likely occur)
hukkin
force-pushed
the
sync-upstream-commit-49ca65b
branch
from
fe0e4e7 to
ddf1634
Compare
2 participants
(previously, markdown-it would likely go into infinite loop instead)
This really is a port of upstream changes markdown-it/markdown-it@13.0.1...49ca65b which adds up to just one changelog entry (the PR title).