Open
Conversation
BNAndras
reviewed
Mar 19, 2026
| -- `ipairs` stops at the first index gap. Seems to me, the | ||
| -- easiest way to render an arbitrary list of lists is to | ||
| -- stringify it back into JSON, and then munge the string. | ||
| -- Unfortunately, we seem to lose _trailing_ nulls this way. |
Member
There was a problem hiding this comment.
json.decode has three parameters per https://dkolf.de/dkjson-lua/documentation. The third one lets us specify a replacement value besides the default nil for nulls in the JSON. The page documents a json.null for setting an explicit null value. In bin/generate-spec, we use canonical_data = json.decode read_file canonical_data_path, but we could instead use canonical_data = json.decode (read_file canonical_data_path), 1, json.null. That'll keep the trailing nulls in place although we'd still need to represent them as "null" in the final tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.