Add support for StringIO input in Exiftool#55
Merged
morozgrafix merged 2 commits intoexiftool-rb:masterfrom Mar 12, 2026
Merged
Add support for StringIO input in Exiftool#55morozgrafix merged 2 commits intoexiftool-rb:masterfrom
morozgrafix merged 2 commits intoexiftool-rb:masterfrom
Conversation
StringIO doesn't inherit IO, so it needs to be checked explicitly
Contributor
Author
|
@morozgrafix can you please accept and release? |
Member
|
Sorry I was away and wasn't able to take a look at your PR. It seems that we have tests failing all over the place, but I don't think it is related to your PR. I'm going to try to fix this first. |
Member
Contributor
Author
|
Rebased, everything looks fine now. |
Member
|
Thank you for your contribution @bogdan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringIO doesn't inherit IO, so it needs to be checked explicitly