Update app to handle riseset module changes#2
Merged
Conversation
The riseset module (v1.0.1-0.20260220080739-24891d86367a) added two new boolean fields to RiseSet: AlwaysAbove and AlwaysBelow, which distinguish "object never sets" (midnight sun) from "object never rises" (polar night). Previously both cases returned "-" for Rise and Set with no way to tell them apart. Changes: - go.mod/go.sum: upgrade to new riseset pseudo-version with the new fields - moon.go: use named constants riseset.Moon and riseset.Sun instead of magic numbers 1 and 2; new JSON fields are included automatically - calendar.html: render "Always above" / "Always below" in the table instead of showing "-" for polar day/night conditions - static/script.js: handle AlwaysAbove and AlwaysBelow in the /gettimes JSON response, displaying a descriptive message in the Rise/Set fields https://claude.ai/code/session_01T2dm9m2XwVaWyvAx6CDfhM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The riseset module (v1.0.1-0.20260220080739-24891d86367a) added two new boolean fields to RiseSet: AlwaysAbove and AlwaysBelow, which distinguish "object never sets" (midnight sun) from "object never rises" (polar night). Previously both cases returned "-" for Rise and Set with no way to tell them apart.
Changes:
https://claude.ai/code/session_01T2dm9m2XwVaWyvAx6CDfhM