Skip to content

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Jan 26, 2026

Why

This adds a new command eas preview:go that is the same as eas update but hardcodes the flags added in #3339.

How

Add new command that composes the other but hardcodes the argv.

Test Plan

eas preview:go (works, does update)

$ neas preview:go --source-maps false
Unexpected arguments: --source-maps, false
See more help with --help

Copy link
Member Author

wschurman commented Jan 26, 2026

@wschurman wschurman marked this pull request as ready for review January 26, 2026 19:45
@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Size Change: -3.88 kB (-0.01%)

Total Size: 53.2 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.2 MB -3.88 kB (-0.01%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.69%. Comparing base (4d04463) to head (9b3e3c8).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/preview/go.ts 69.24% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3345      +/-   ##
==========================================
+ Coverage   49.67%   49.69%   +0.02%     
==========================================
  Files         671      673       +2     
  Lines       28018    28037      +19     
  Branches     5802     5802              
==========================================
+ Hits        13914    13929      +15     
- Misses      12916    12920       +4     
  Partials     1188     1188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman changed the base branch from wschurman/01-26-_eas-cli_remove_commented-out_code_in_eas_update_command to graphite-base/3345 January 27, 2026 06:08
@wschurman wschurman force-pushed the wschurman/01-26-_eas-cli_add_eas_preview_go_command branch from 9b02ad4 to 77077ee Compare January 27, 2026 06:08
@graphite-app graphite-app bot changed the base branch from graphite-base/3345 to main January 27, 2026 06:09
@wschurman wschurman force-pushed the wschurman/01-26-_eas-cli_add_eas_preview_go_command branch from 77077ee to 9b3e3c8 Compare January 27, 2026 06:09
@github-actions
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants