fix(vm): preserve int64/uint64 precision in arithmetic#946
Open
eyupcanakman wants to merge 2 commits intoexpr-lang:masterfrom
Open
fix(vm): preserve int64/uint64 precision in arithmetic#946eyupcanakman wants to merge 2 commits intoexpr-lang:masterfrom
eyupcanakman wants to merge 2 commits intoexpr-lang:masterfrom
Conversation
…32-bit On 32-bit architectures, arithmetic operations between int64 operands silently truncated to int (32-bit), causing overflow. Fix the code generator to promote result type to int64/uint64 when either operand is int64/uint64. Fixes expr-lang#804
…ness Avoid mixed-sign regression where int64 + uint64 would incorrectly promote to uint64, causing wrong results for negative values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arithmetic between two
int64values (or twouint64values) goes throughint, which truncates on 32-bit platforms. The generated runtime helpers had no specialization for 64-bit types.The code generator now emits
int64cases when both operands are signed and at least one isint64, anduint64when both are unsigned and at least one isuint64. Mixed signed/unsigned stays asint.Fixes #804