docs: add general labels documentation for issues and PRs#342
Open
bjohansebas wants to merge 6 commits intoexpressjs:masterfrom
Open
docs: add general labels documentation for issues and PRs#342bjohansebas wants to merge 6 commits intoexpressjs:masterfrom
bjohansebas wants to merge 6 commits intoexpressjs:masterfrom
Conversation
Member
Author
|
cc: @expressjs/triagers |
UlisesGascon
approved these changes
Feb 25, 2025
wesleytodd
approved these changes
Mar 4, 2025
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
In general this is GREAT. I added a few nitpick comments but will just drop an approval since I think they are easy to resolve.
docs/triage/labels.md
Outdated
| | -------------------- | ----------------------------------------------------------------------------------- | | ||
| | `bug` | Denotes confirmed bugs. | | ||
| | `duplicate` | A duplicate issue. | | ||
| | `enhancement` | An issue requesting an enhancement. | |
Member
There was a problem hiding this comment.
Suggested change
| | `enhancement` | An issue requesting an enhancement. | | |
| | `enhancement` | An issue requesting or implementing an enhancement. | |
docs/triage/labels.md
Outdated
| | `bug` | Denotes confirmed bugs. | | ||
| | `duplicate` | A duplicate issue. | | ||
| | `enhancement` | An issue requesting an enhancement. | | ||
| | `help wanted` | Extra help may be needed to resolve this issue. | |
Member
There was a problem hiding this comment.
Suggested change
| | `help wanted` | Extra help may be needed to resolve this issue. | | |
| | `help wanted` | Help from the community is requested to assist in resolving this issue. | |
docs/triage/labels.md
Outdated
| | `enhancement` | An issue requesting an enhancement. | | ||
| | `help wanted` | Extra help may be needed to resolve this issue. | | ||
| | `invalid` | This is not a proper issue report, request, or question. | | ||
| | `question` | For issues where the issuer is asking something. | |
Member
There was a problem hiding this comment.
We have been moving these into discussions, which IMO is better than using a label. Could we just remove this?
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
bjohansebas
commented
May 29, 2025
Comment on lines
+18
to
+21
| - `needs triage`: This can be kept if the triager is unsure which next steps to take | ||
| - `awaiting more info`: If more info has been requested from the author, apply this label. | ||
| - `bug`: Issues that present a reasonable conviction there is a reproducible bug. | ||
| - `enhancement`: Issues that are found to be a reasonable candidate feature additions. |
Member
Author
There was a problem hiding this comment.
These changes were made by the linter
UlisesGascon
approved these changes
Jun 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed in #294 about having the labels documented at the organizational level, so that new triagers know how to use them. Part of this was extracted from https://github.com/jshttp/style-guide?tab=readme-ov-file#issue-label-use.