Skip to content

Conversation

@GroophyLifefor
Copy link
Member

@GroophyLifefor GroophyLifefor commented Jan 18, 2026

Remove duplicate test cases:

  • Remove duplicate "should encode data uri2" test from res.location.js (original at line 49: "should encode data uri1")
  • Remove duplicate "should not override previous Content-Types" test from res.jsonp.js (original at line 130: "should not override previous Content-Types with no callback")

Review wanted to @bjohansebas

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I’d like to give Wes a bit of time in case he has some context about the repeated res.location test, since he wrote those tests. If not, I’ll come back in a week and merge it.

Side note: please don’t tag people in the description to request reviews, we all watch the repositories.

.expect(200, done)
})

it('should encode data uri1', function (done) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('should encode data uri', function (done) {

If the duplicate test is removed, I think the suffix can also be removed. Suffixes have been added in c96c690.

This duplicate test seems to have been a mistake - #5561 (comment) (check reactions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants